Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken windows build #3562

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fix broken windows build #3562

merged 1 commit into from
Mar 13, 2024

Conversation

sgpearse
Copy link
Collaborator

Fix #3561 by using size_t instead of UL.

@StasJ are there any implications for this fix? Windows is being fussy about the size_t/UL type mismatch.

@sgpearse sgpearse requested a review from StasJ March 13, 2024 18:21
StasJ
StasJ approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@StasJ StasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StasJ are there any implications for this fix? Windows is being fussy about the size_t/UL type mismatch

No, it’s the same thing

@sgpearse sgpearse merged commit 03fe635 into main Mar 13, 2024
1 of 2 checks passed
@sgpearse sgpearse deleted the issue3561 branch October 22, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StasJ StasJ StasJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken Windows Build
2 participants
@sgpearse @StasJ