Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new xcollection serializer #54

Merged
merged 6 commits into from
Dec 1, 2021

Conversation

mgrover1
Copy link
Contributor

@mgrover1 mgrover1 commented Nov 29, 2021

This is a first cut at adding an xcollection (collection of datasets) serializer to funnel - there is something going wrong here, in regards to serialization, so this is still a draft....

ci/environment.yml Outdated Show resolved Hide resolved
@mgrover1
Copy link
Contributor Author

I found the culprit 😊 turns out this section was important

@pick_serializer.register(xc.Collection)
def _(obj):
    return registry.serializers.get('xcollection')().name

@andersy005
Copy link
Contributor

I found the culprit 😊 turns out this section was important

@pick_serializer.register(xc.Collection)
def _(obj):
    return registry.serializers.get('xcollection')().name

I'm curious... This shouldn't be necessary when you explicitly specify the serializer to be xcollection. Were you using the auto serializer option before?

@mgrover1
Copy link
Contributor Author

mgrover1 commented Dec 1, 2021

I found the culprit 😊 turns out this section was important

@pick_serializer.register(xc.Collection)
def _(obj):
    return registry.serializers.get('xcollection')().name

I'm curious... This shouldn't be necessary when you explicitly specify the serializer to be xcollection. Were you using the auto serializer option before?

It was using the auto serializer in the tests...

ci/environment.yml Outdated Show resolved Hide resolved
Co-authored-by: Anderson Banihirwe <axbanihirwe@ualr.edu>
Copy link
Contributor

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Max! This looks great 👍🏽

@andersy005 andersy005 merged commit 7b8d3a2 into NCAR:main Dec 1, 2021
@andersy005 andersy005 added the enhancement New feature or request label Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants