-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new xcollection serializer #54
Conversation
for more information, see https://pre-commit.ci
I found the culprit 😊 turns out this section was important @pick_serializer.register(xc.Collection)
def _(obj):
return registry.serializers.get('xcollection')().name |
…er1/esds-funnel into add_xcollection_serializer
I'm curious... This shouldn't be necessary when you explicitly specify the serializer to be |
It was using the |
Co-authored-by: Anderson Banihirwe <axbanihirwe@ualr.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Max! This looks great 👍🏽
This is a first cut at adding an xcollection (collection of datasets) serializer to funnel - there is something going wrong here, in regards to serialization, so this is still a draft....