Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CONTRIBUTING.md #244

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Create CONTRIBUTING.md #244

merged 2 commits into from
Aug 28, 2023

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Aug 16, 2023

Related to #160

@jukent jukent requested a review from a team as a code owner August 16, 2023 16:18
@jukent jukent requested review from dcherian, rmshkv and katiedagon and removed request for a team August 16, 2023 16:18
Copy link
Contributor

@katiedagon katiedagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for converting my google doc into markdown @jukent! It looks good to me, though I'm curious if others have additional steps/tips on this workflow, since it was my first time going through it.

@clyne clyne merged commit 863b000 into NCAR:main Aug 28, 2023
1 check passed
@clyne
Copy link
Contributor

clyne commented Aug 28, 2023

My only comment is that this document describes a "forking workflow", which supports contributions from external developers (folks that don't have write access to the repository). The workflow can be simplified somewhat (eliminate the need for forking and creating a separate repo), if all of the contributors have write access.

@katiedagon
Copy link
Contributor

@clyne I was thinking that even for internal folks with write access, we would want to encourage the forking/PR process to review new blog posts. But I may have an incomplete understanding of the different ways this process can work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants