Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up ASV benchmarking #474

Merged
merged 12 commits into from
Sep 21, 2023
Merged

Set up ASV benchmarking #474

merged 12 commits into from
Sep 21, 2023

Conversation

anissa111
Copy link
Member

@anissa111 anissa111 commented Sep 19, 2023

PR Summary

Closes #471

I realize there's not a great way to verify that this works just from this PR. To test this locally, I suggest checking out this branch, making the asv_bench environment, and trying it for yourself with:

asv run v2023.09.0^!
asv publish
asv preview 

The next step will be to connect this to CI in geocat-comp that will send the results over to geocat-comp-asv

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@anissa111 anissa111 added developer feature For development standardization / best practices / enhancement testing Issue related to testing scalability and performance Related to scalability, performance, or benchmarking labels Sep 19, 2023
@anissa111 anissa111 marked this pull request as ready for review September 19, 2023 19:06
Copy link
Contributor

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Looks good.

And got this running locally as well (though had to run something different - I think because I didn't have the version tag).

Anyway, looks good to me!

@anissa111 anissa111 merged commit d8719fd into NCAR:main Sep 21, 2023
9 checks passed
@anissa111 anissa111 deleted the asv branch September 21, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer feature For development standardization / best practices / enhancement scalability and performance Related to scalability, performance, or benchmarking testing Issue related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up asv benchmarking
2 participants