Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fourier filter to comp #511

Merged
merged 4 commits into from Nov 8, 2023
Merged

Add fourier filter to comp #511

merged 4 commits into from Nov 8, 2023

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Nov 8, 2023

PR Summary

Removing this example from geocat-examples and adding it to comp.
Closes #258

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

Examples

  • Any new notebook examples added to docs/examples/ folder
  • Pre-run all notebook cells
  • New notebook files added to docs/examples.rst toctree
  • New notebook files added to new entry in docs/gallery.yml with appropriate thumbnail photo in docs/_static/thumbnails/

@jukent jukent added documentation Improvements or additions to documentation tutorial example, tutorial, presentation, or showcase labels Nov 8, 2023
@jukent jukent requested a review from anissa111 November 8, 2023 20:38
@anissa111 anissa111 marked this pull request as ready for review November 8, 2023 20:45
@anissa111 anissa111 merged commit 0a20812 into NCAR:main Nov 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tutorial example, tutorial, presentation, or showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UMBRELLA ISSUE: Migration of geocat-comp examples to this repository from geocat-examples
2 participants