Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 Support #548

Merged
merged 8 commits into from
Feb 6, 2024
Merged

Python 3.12 Support #548

merged 8 commits into from
Feb 6, 2024

Conversation

cyschneck
Copy link
Contributor

@cyschneck cyschneck commented Feb 5, 2024

PR Summary

Closes #483

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@cyschneck cyschneck added the feature a new feature that is going to be developed label Feb 5, 2024
@cyschneck cyschneck self-assigned this Feb 5, 2024
@cyschneck
Copy link
Contributor Author

  • Update documentation to include 3.12 (README.md)
  • Update build environments (setup.cfg, docs.yml, environment.yml)
  • Workflow releases and pytests (ci-release.yml, ci.yml)
  • Check Python 3.12.0 compatibility for existing dependency packages

Version Number not Available

  • eofs (version number = "unknown" -> from except ImportError, but package working)
  • pre-commit (no version number)

Compatible Packages

  • cf_xarray (running 0.8.8)
  • cftime (running 1.6.3)
  • dask (running 2024.1.1)
  • distributed (running 2024.1.1)
  • eofs
  • metpy (running 1.6.1)
  • numba (running 0.59.0)
  • numpy (running 1.26.3)
  • scipy (running 1.12.0)
  • pandas (running 2.2.0)
  • pint (running 0.23)
  • xarray (running 2024.1.1)
  • xskillscore (running 0.0.24)
  • geocat-datafiles (running 2021.1.0)
  • parameterized (running 0.9.0)
  • pytest (running 8.0.0)
  • pytest-cov (running 4.1.0)

@cyschneck
Copy link
Contributor Author

Drop Python 3.9 support in the spring (#553)

@cyschneck cyschneck marked this pull request as ready for review February 6, 2024 18:33
Copy link
Contributor

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

It does add a number of tests to the CI with the additional Python version running for all of the platforms. @anissa111 are you good with that or is it worth thinning things down a bit?

@anissa111
Copy link
Member

This looks good to me.

It does add a number of tests to the CI with the additional Python version running for all of the platforms. @anissa111 are you good with that or is it worth thinning things down a bit?

I think if we're going to continue supporting all the versions, we do need to test against them all. The tests (at least for the most part) run pretty quickly, I think we should be okay until April.

Copy link
Member

@anissa111 anissa111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@anissa111 anissa111 merged commit 90dc4e4 into NCAR:main Feb 6, 2024
15 checks passed
@cyschneck cyschneck deleted the python_12_483 branch February 6, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a new feature that is going to be developed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support python 3.12
3 participants