Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin ASV #567

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Unpin ASV #567

merged 1 commit into from
Feb 27, 2024

Conversation

anissa111
Copy link
Member

@anissa111 anissa111 commented Feb 27, 2024

PR Summary

Closes #555

ASV released 0.6.3 with a fix for the issue we encountered in #555.

It still prints out the libmamba warning, but continues to correctly run the benchmarks afterward:

(asv-bench) ➜  benchmarks git:(unpin_asv) pip install asv=="0.6.1"
Collecting asv==0.6.1
...
Installing collected packages: asv
  Attempting uninstall: asv
    Found existing installation: asv 0.6.3
    Uninstalling asv-0.6.3:
      Successfully uninstalled asv-0.6.3
Successfully installed asv-0.6.1
(asv-bench) ➜  benchmarks git:(unpin_asv) asv check               
· Discovering benchmarks
·· Uninstalling from conda-py3.10-python
·· Building d61ec65f <unpin_asv> for conda-py3.10-python.
·· Installing d61ec65f <unpin_asv> into conda-py3.10-python.
· Checking benchmarks
·· No problems found.

(asv-bench) ➜  benchmarks git:(unpin_asv) pip install asv=="0.6.3"
...
Installing collected packages: asv
  Attempting uninstall: asv
    Found existing installation: asv 0.6.1
    Uninstalling asv-0.6.1:
      Successfully uninstalled asv-0.6.1
Successfully installed asv-0.6.3

(asv-bench) ➜  benchmarks git:(unpin_asv) asv check               
Couldn't load asv.plugins._mamba_helpers because
No module named 'libmambapy'
· Discovering benchmarks
· Checking benchmarks
·· No problems found.

(asv-bench) ➜  benchmarks git:(unpin_asv) asv run d61ec65^!
Couldn't load asv.plugins._mamba_helpers because
No module named 'libmambapy'
· Creating environments
· Discovering benchmarks
· Running 1 total benchmarks (1 commits * 1 environments * 1 benchmarks)
[ 0.00%] · For geocat-comp commit d61ec65f <unpin_asv>:
[ 0.00%] ·· Benchmarking conda-py3.10-python
[50.00%] ··· Running (import.Import.timeraw_import_geocat_comp--).
[100.00%] ··· import.Import.timeraw_import_geocat_comp          

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • [n/a] Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@anissa111 anissa111 added dependencies Pull requests that update a dependency file testing Issue related to testing labels Feb 27, 2024
@anissa111 anissa111 marked this pull request as ready for review February 27, 2024 19:28
@anissa111 anissa111 merged commit d0158db into NCAR:main Feb 27, 2024
15 checks passed
@anissa111 anissa111 deleted the unpin_asv branch February 27, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file testing Issue related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Failure: ASV
2 participants