mask_2

[hCraker]

Closes #188

[hCraker]

In the NCL example, the contours appear over lakes. I have played around with zorder but have been unable to achieve the same result. @clairefio @michaelavs have either of you done this before?

[michaelavs]

In the NCL example, the contours appear over lakes. I have played around with zorder but have been unable to achieve the same result. @clairefio @michaelavs have either of you done this before?

I did something semi-similar in my mask_5 example, but I was only drawing over land which covered the lakes so it may not work the same because I think you will be drawing over 2 separate objects. I believe I used this stack overflow question as a basis for my line of code, so It may be of use to you

[hCraker]

I did something semi-similar in my mask_5 example, but I was only drawing over land which covered the lakes so it may not work the same because I think you will be drawing over 2 separate objects. I believe I used this stack overflow question as a basis for my line of code, so It may be of use to you

I think the issue stems from the LAND feature in cartopy covering where lakes are. I would have to find a feature that draws land masses but doesn't cover lakes, and I don't think cartopy has that. I could use a shapefile, but I don't know if it would be worth adding to the example since shapefiles are a bit complicated. I'll continue to work on this but if you and @clairefio could review this PR with this in mind, that would be helpful.

[clairefio]

I did something semi-similar in my mask_5 example, but I was only drawing over land which covered the lakes so it may not work the same because I think you will be drawing over 2 separate objects. I believe I used this stack overflow question as a basis for my line of code, so It may be of use to you

I think the issue stems from the LAND feature in cartopy covering where lakes are. I would have to find a feature that draws land masses but doesn't cover lakes, and I don't think cartopy has that. I could use a shapefile, but I don't know if it would be worth adding to the example since shapefiles are a bit complicated. I'll continue to work on this but if you and @clairefio could review this PR with this in mind, that would be helpful.

The rest of the script looks good! Here's an interesting thread: https://stackoverflow.com/questions/13796315/plot-only-on-continent-in-matplotlib Maybe you could tweak this solution to plot contour data on the lakes?

[hCraker]

The rest of the script looks good! Here's an interesting thread: https://stackoverflow.com/questions/13796315/plot-only-on-continent-in-matplotlib Maybe you could tweak this solution to plot contour data on the lakes?

Thank you for the suggestions, but that stack overflow thread uses matplotlib.basemap instead of cartopy. Thank you for searching for a solution.

[michaelavs]

Great work!

[clyne]

Terrific. Nice work!

[jukent]

Here is an example of creating a custom cartopy shape feature:
https://geocat-examples.readthedocs.io/en/latest/gallery/Overlays/NCL_overlay_11a.html#sphx-glr-gallery-overlays-ncl-overlay-11a-py

You might need to make a new land file that excludes area in the lake feature.

[hCraker]

Here is an example of creating a custom cartopy shape feature:
https://geocat-examples.readthedocs.io/en/latest/gallery/Overlays/NCL_overlay_11a.html#sphx-glr-gallery-overlays-ncl-overlay-11a-py

You might need to make a new land file that excludes area in the lake feature.

I will look into that and see what I can do. Thanks for the link

[hCraker]

@jukent I've been having issues trying to mask only the land masses and not the lakes using cartopy and natural earth shape files. I tried looking for a shape file that already had what I wanted, but I couldn't find one. We may want to merge this PR as is and work on creating an appropriate shape file later.

[jukent]

Creating a shape file for land sans lakes seems like appropriate for a separate geocat-viz issue.

[erogluorhan]

Great work!