Adding patch_inference.py #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djgagne
requested changes
Aug 14, 2020
There was a problem hiding this comment.
The code generally looks good. One thing I would like to see included is reshaping the data into the GLM grid dimensions before outputting to CSV. The overall workflow would be:
- Extract ABI patches at each GLM grid cell at a given time and save those to netCDF.
- Feed the patches into the inference script and generate predictions for each patch that are then reshaped into the GLM grid dimension.
- Output the gridded predictions to netCDF.
scripts/patch_inference.py
Outdated
| print("Performing inference",flush=True) | ||
| y_hat = model.predict(abi_data) | ||
|
|
||
| y_hat = y_hat.reshape((len(y_hat),)) |
There was a problem hiding this comment.
Would it be possible to reshape the predictions into the shape of the GLM grid the patches are derived from instead of leaving it as a 1D vector?
There was a problem hiding this comment.
Sure, I've reshaped the output to match the dimensions and format of the GLM nc files.
…LM gridded nc files
djgagne
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.