Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify full_ic_frq mod for gfortran compiler and start j loop from 1 … #128

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

CharlesZheZhang
Copy link
Collaborator

Copy link
Collaborator

@cenlinhe cenlinhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug fix looks good to me.

@cenlinhe
Copy link
Collaborator

Note that this issue/bug only occurs in gfortran compiler but not intel and pgi, probably because gfortran compiler has a stricter rule on this.

Copy link
Collaborator

@tslin2 tslin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good.

@cenlinhe
Copy link
Collaborator

@tslin2 from my end, it seems that you have not approved this PR, so that I cannot merge it. Could you please check?
image

Copy link
Collaborator

@tslin2 tslin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@tslin2 tslin2 self-requested a review November 14, 2023 16:28
@cenlinhe cenlinhe added the bug Something isn't working label Nov 14, 2023
Copy link
Collaborator

@tslin2 tslin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes!

@tslin2 tslin2 self-requested a review November 14, 2023 16:34
Copy link
Collaborator

@tslin2 tslin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants