-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify full_ic_frq mod for gfortran compiler and start j loop from 1 … #128
Conversation
…in reading netcdf variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bug fix looks good to me.
Note that this issue/bug only occurs in gfortran compiler but not intel and pgi, probably because gfortran compiler has a stricter rule on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good.
@tslin2 from my end, it seems that you have not approved this PR, so that I cannot merge it. Could you please check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve these changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approval
…in reading netcdf variables
This commit is to avoid full_ic_frq == 0 in mod function used in gfortran compiler.
https://github.com/CharlesZheZhang/hrldas/blob/789b8c21c9f2f0a1811dd43ee4677a43453817f5/hrldas/HRLDAS_forcing/create_forcing.F#L445
Also change j loop from 1 in reading netcdf variables.
https://github.com/CharlesZheZhang/hrldas/blob/789b8c21c9f2f0a1811dd43ee4677a43453817f5/hrldas/HRLDAS_forcing/create_forcing.F#L2119