Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

59 Setup MICM for MUSICA #71

Merged
merged 12 commits into from
May 25, 2023
Merged

Conversation

K20shores
Copy link
Collaborator

@K20shores K20shores commented May 24, 2023

This, with NCAR/musica#19, closes #58. The branch name doesn't actually have anything to do with the work I did.

  • Removes the C and fortran interfaces to micm. These now live in the MUSICA library
  • Rewrote some of the CMake files so that MICM now is installed as a header only library
  • Removes the tests for openmp and MPI. No tests actually use these right now. Also, now that the MICM target is header only, you can't link libraries to it. We would need to write tests that use OpenMP or MPI and link the test targets to those libraries

@K20shores K20shores changed the title 59 put micm in an environment module 59 Setup MICM for MUSICA May 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +73.60 🎉

Comparison is base (b89f9ff) 0.00% compared to head (9e594d5) 73.60%.

Additional details and impacted files
@@            Coverage Diff            @@
##           main      #71       +/-   ##
=========================================
+ Coverage      0   73.60%   +73.60%     
=========================================
  Files         0       14       +14     
  Lines         0      701      +701     
=========================================
+ Hits          0      516      +516     
- Misses        0      185      +185     
Impacted Files Coverage Δ
include/micm/version.hpp 100.00% <100.00%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@K20shores K20shores merged commit fbb09c5 into main May 25, 2023
@K20shores K20shores deleted the 59-put-micm-in-an-environment-module branch May 25, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fortran interface to CCPP that does nothing but has the standard CCPP functions and a meta-data file
4 participants