Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global vars causing duplicate symbol errors with gcc10 #150

Merged

Conversation

Dave-Allured
Copy link
Contributor

Fixes for 4 duplicate symbol errors with gcc10.
Closes #148

Change several global vars to extern or static (i.e. private use).
Caused by change in gcc10 from default -fcommon to -fno-common.
Refer to gcc10 release notes.
This is better than -fcommon across the board.

Fix for duplicate symbol errors with gcc10.
Base definition for these 3 globals are in NclGlobalVars.h.
This is better than -fcommon.
Fix for duplicate symbol error with gcc10.
This one is local use only, and should never have been global.
Fix for duplicate symbol error with gcc10.
This one is local use only, and should never have been global.
@erogluorhan erogluorhan changed the base branch from develop to duplicate-symbols July 9, 2021 18:33
@erogluorhan erogluorhan merged commit 5b1cfcc into NCAR:duplicate-symbols Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate symbol errors with gcc10
2 participants