Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inferred Edge Should Match Query Graph Edge - MVP1 #872

Closed
sstemann opened this issue Jul 19, 2024 · 8 comments
Closed

Inferred Edge Should Match Query Graph Edge - MVP1 #872

sstemann opened this issue Jul 19, 2024 · 8 comments
Assignees
Labels
Fugu (Sprint 4) - due July 19 in CI This ticket will be fixed in CI by the end of Fugu/Sprint 4 (July 19) treats

Comments

@sstemann
Copy link

UI Test > MVP1 > Cystic Fibrosis
https://ui.test.transltr.io/main/results?l=Cystic%20Fibrosis&i=MONDO:0009061&t=0&r=0&q=01f390c0-0d65-4dcc-a6ea-4b1749ec10b2

Look for Result Ritonavir
image

image

image

ARAX - Treats Or Applied Or Studied To Treat - Support Graph
image

BTE - Treats Or Applied Or Studied To Treat - DIrect
image

ARAGORN responded with 0 results, Ritonavir was not in the results from Improve or Unsecret.

@sstemann
Copy link
Author

related to #871 and #870

@sstemann sstemann changed the title Are TMKP One-hop edges Lookups/Direct Paths? Are TMKP One-hop edges Lookups/Direct Paths? In the UI? In the ARA? Jul 19, 2024
@cbizon
Copy link
Collaborator

cbizon commented Jul 19, 2024

I split out out the ARAGORN issue (0 results) from this one, and removed aragorn people.

@cbizon cbizon removed their assignment Jul 19, 2024
@cbizon
Copy link
Collaborator

cbizon commented Jul 19, 2024

It looks to me from the ARAX interface that both ARAX and BTE are returning an edge with a "treats or applied or ..." rather than the requested "treats" edge. I think that if these don't match then there's an inference and this should be shown as a support graph rather than the top level result.

@sstemann
Copy link
Author

@cbizon i included you as architecture because I wasn't sure where this decision about treats/inferred lives.

@cbizon
Copy link
Collaborator

cbizon commented Jul 22, 2024

Oh, gotcha, thanks

@colleenXu
Copy link

colleenXu commented Aug 15, 2024

There is now a fix deployed to BTE CI. BTE should now return "an inferred treats edge with the tmkp edge in a support graph" - which is what Chris Bizon recommended.

@sstemann sstemann changed the title Are TMKP One-hop edges Lookups/Direct Paths? In the UI? In the ARA? Inferred Edge Should Match Query Graph Edge Aug 16, 2024
@sstemann sstemann changed the title Inferred Edge Should Match Query Graph Edge Inferred Edge Should Match Query Graph Edge - MVP1 Aug 16, 2024
@sierra-moxon
Copy link
Member

closing as complete with Colleen's comment and Chris's comment about splitting the other work into a different ticket.
also retested on CI b/c I wasn't sure if TEST was ready for testing yet, and CI is no longer showing the longer predicate in the inferred area, just the support path area.

@sstemann
Copy link
Author

sstemann commented Sep 3, 2024

this is resolved in Prod, Fugu

@sstemann sstemann added Fugu (Sprint 4) - due July 19 in CI This ticket will be fixed in CI by the end of Fugu/Sprint 4 (July 19) and removed Guppy (Sprint 5) - due Aug 23 in CI This ticket will be fixed in CI by the end of Guppy (Sprint 5) (Aug 23) labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fugu (Sprint 4) - due July 19 in CI This ticket will be fixed in CI by the end of Fugu/Sprint 4 (July 19) treats
Projects
None yet
Development

No branches or pull requests

6 participants