added solr startup check. Refactored to make props available #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and future checks. Added tests
taojing2002
reviewed
Jul 5, 2023
|
|
||
| // can read? | ||
| defaultProperties.load(Files.newBufferedReader(defaultPropsFilePath)); | ||
| // can write? Use isWriteable() so we don't mess up props file formatting for Jing :-) |
There was a problem hiding this comment.
Thanks. But the metacat.properties file is still changed :). I believe it happens when we write some properties (such as status) into the file.
There was a problem hiding this comment.
agreed - I just thought I would be better not to have it happen in yet another place :-)
taojing2002
reviewed
Jul 5, 2023
|
|
||
| Properties siteProperties = new Properties(); | ||
| runtimeProperties = new Properties(defaultProperties); |
There was a problem hiding this comment.
Is there any reason why we need the defaultProperties to initialize the runtimeProperties? If we just use the default constructor to initialize the runtimeProperties object, we can only has one parameter in the method signature.
taojing2002
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1631