-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 1727 sphinx7 #1728
Feature 1727 sphinx7 #1728
Conversation
Also include mermaid extension, and fix deprecated `style` key in layout.
Oh, and by the way -- while I added the mermaid diagram from @doulikecookiedough , the build for that using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! But do you really mean to modify those 15 images files, Matt?
@taojing2002 yes, I intended to add the images. when you rerun the sphinx generator it generates new image files which are different from the old ones. So, by checking these in now, when other people regenerate them it shouldn't generate any changes. |
can we merge this, @mbjones ? |
Yes, feel free if its working for you. It worked for me, and I felt it would improve things. But its up to you and Jing if it looks like an improvement. |
Support recent versions of python3 and sphinx 7 for admindoc builds. Test with
ant admindoc
. Older versions of sphinx should also work, starting with the first version that supported thestyles
key, but I had a hard time determining which version that was from the sphinx release notes. The python changes are to changeSafeConfigParser
(a python 2.7 fixture) which was replaced withConfigParser
and some methods renamed/refactored. I think any python after 3.2 would work, but I only tested against 3.10 and 3.11.