Feature 1716-mn-reindex #1738
Merged
Feature 1716-mn-reindex #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ex; otherwise false.
artntek
requested changes
Nov 20, 2023
src/edu/ucsb/nceas/metacat/restservice/v2/MNResourceHandler.java
Outdated
Show resolved
Hide resolved
src/edu/ucsb/nceas/metacat/restservice/v2/MNResourceHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Can we rename to MNodeServiceIT?
test/edu/ucsb/nceas/metacat/index/queue/FailedIndexResubmitTimerTaskTestIT.java
Outdated
Show resolved
Hide resolved
artntek
requested changes
Nov 27, 2023
| if (resourceMapFormatList != null && resourceMapFormatList.size() > 0) { | ||
| for (String format : resourceMapFormatList) { | ||
| if (format != null && !format.trim().equals("")) { | ||
| if (firstTime) { | ||
| sql = sql + " where object_format !='" + format + "'"; | ||
| sql.append(" where object_format !='" + format + "'"); |
There was a problem hiding this comment.
Still has string concatenation
| firstTime = false; | ||
| } else { | ||
| sql = sql + " and object_format !='" + format + "'"; | ||
| sql.append(" and object_format !='" + format + "'"); |
There was a problem hiding this comment.
Still has string concatenation
| if (resourceMapFormatList != null && resourceMapFormatList.size() > 0) { | ||
| boolean firstTime = true; | ||
| for (String format : resourceMapFormatList) { | ||
| if (format != null && !format.trim().equals("")) { | ||
| if (firstTime) { | ||
| sql = sql + " where object_format ='" + format + "'"; | ||
| sql.append(" where object_format ='" + format + "'"); |
There was a problem hiding this comment.
Still has string concatenation
| firstTime = false; | ||
| } else { | ||
| sql = sql + " or object_format ='" + format + "'"; | ||
| sql.append(" or object_format ='" + format + "'"); |
There was a problem hiding this comment.
Still has string concatenation
artntek
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch focuses on moving the reindex action from the old Metacat api to the new DataONE MN.admin api.