Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1631 startup changes #1752

Merged
merged 6 commits into from
Dec 6, 2023
Merged

Feature 1631 startup changes #1752

merged 6 commits into from
Dec 6, 2023

Conversation

artntek
Copy link
Contributor

@artntek artntek commented Dec 6, 2023

Changes to the startup checks (and associated tests):

  • Fixed: some tests were passing incorrectly - the test expectation was a RuntimeException, but they were throwing a NullPointerException. However, this was interpreted as a pass because a NullPointerException IS a RuntimeException. Solved by checking for the specific Exception Message.
  • Added logic to skip availability check for solr, if solr has never been configured before, since legacy deployments require metacat to be operational under these circumstances, so the operator can enter the correct properties in the admin pages
  • Changed the solr check logic so it ensures the schema is retrievable, instead of simply relying on receiving an HTTP 200
  • Removed implements ServletContextListener and associated annotations, since this will now be called from Jing's new MetacatInitializer class
  • Renamed StartupRequirementsListener (and test) to StartupRequirementsChecker, since it's no longer a listener.

@artntek artntek merged commit 5e4b6bc into develop Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants