Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add portal section name to the URL until one is clicked #1066

Closed
laurenwalker opened this issue Aug 22, 2019 · 2 comments
Closed

Don't add portal section name to the URL until one is clicked #1066

laurenwalker opened this issue Aug 22, 2019 · 2 comments
Assignees
Labels
Portal Editor portals Anything related to portals
Milestone

Comments

@laurenwalker
Copy link
Member

In the portal view and portal editor view, we shouldn't automatically add the section name to the URL until the user has clicked on another section. This keeps the URL in the window as the direct portal URL (e.g. https://site.com/portals/my-portal) unless there is further navigation.

@laurenwalker laurenwalker added Portal Editor portals Anything related to portals labels Aug 22, 2019
@rushirajnenuji rushirajnenuji added this to the ProjEditor-MVP-2 milestone Aug 22, 2019
@rushirajnenuji rushirajnenuji self-assigned this Sep 3, 2019
rushirajnenuji added a commit that referenced this issue Sep 5, 2019
Reference: #1066
Removing the defaultSection from URL for non-click events
@rushirajnenuji
Copy link
Member

Works for non-click events.

  • TestCase 1: /portal/label

    • Previous behaviors: /portal/label/defaultSection
    • Current behavior: navigates to /portal/label
  • TestCase 2: /portal/SID

    • Previous behaviors: /portal/SID/defaultSection
    • Current behavior: navigates to /portal/label
  • TestCase 3: edit/portal/label

    • Previous behaviors: edit/portal/label/defaultSection
    • Current behavior: navigates to edit/portal/label
  • TestCase 4: edit/portal/SID

    • Previous behaviors: edit/portal/SID/defaultSection
    • Current behavior: navigates to edit/portal/label

@laurenwalker
Copy link
Member Author

Thanks Rushi, the section name is no longer being automatically added to the URL for me. There is an issue with navigating to the portal editor by sid, but I'll comment on that ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Editor portals Anything related to portals
Projects
None yet
Development

No branches or pull requests

2 participants