Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New editor should require submitter email addresses #545

Closed
jagoldstein opened this issue Mar 29, 2018 · 14 comments
Closed

New editor should require submitter email addresses #545

jagoldstein opened this issue Mar 29, 2018 · 14 comments

Comments

@jagoldstein
Copy link

how are we to write back to submitter's if we don't have his/her email address? this field should be required for at least one personnel or organization

@jagoldstein jagoldstein added blocker This issue is blocking progress on other work enhancement editor labels Nov 13, 2018
@dmullen17
Copy link
Member

dmullen17 commented Nov 13, 2018

This would be really great to have, I've spent 30 minutes looking for an email address before.

@jagoldstein
Copy link
Author

I agree with @dmullen17 . I easily spent a half hour trying to track down a submitter's email address yesterday so that I could add it as a "Requestor" in RT. I am still not confident I even obtained a good address to contact the submitter.

Often submitter's enter very sparse metadata, occasionally omitting all email addresses. Additionally, many people intentionally hide their email address from being listed publicly. Even some private universities' websites do not publish students' email addresses (only those with university login credentials can access student directories).

At least one contact email should be required by the editor. Otherwise, submissions may sit as private indefinitely as we cannot contact the submitter. It would be great to prioritize this.

@jeanetteclark
Copy link
Collaborator

jeanetteclark commented Nov 14, 2018

I'll add a plus one to this...it is MUCH harder to retrieve submitter email addresses than you would think since ORCID doesn't expose them. Most of the time a page like this is all we have to go off of:

screen shot 2018-11-14 at 9 19 47 am

It is definitely not uncommon for us to spend 20 minutes trying to track down the best email address for a submitter.

@mbjones
Copy link
Member

mbjones commented Nov 16, 2018

We have a need to switch from using the ORCID public API for authenticating to using the ORCID member API. This switch would allow some new features, one of which is that we could ask the user for permission to view their email from their ORCID profile as a condition of logging in, so we would always have an email for them. I think that would solve this immediate request. This is a DataONE authentication change, described here: https://redmine.dataone.org/issues/8746

@laurenwalker
Copy link
Member

Removing the 'blocker' label since this isn't truly blocking any work - will replace with a priority label.

@laurenwalker laurenwalker added Priority: High and removed blocker This issue is blocking progress on other work labels Jan 13, 2020
@laijasmine
Copy link

We would love to see this feature up soon. It is an issue that still comes up on a regular basis.

@jeanetteclark
Copy link
Collaborator

Yup I agree. The team has wasted untold hours over the years trying to figure out how to contact people.

@laurenwalker
Copy link
Member

That's not good! Ok, I will figure out a way to require this that makes the most sense and get it in soon.

@laurenwalker laurenwalker self-assigned this Oct 14, 2020
@laurenwalker laurenwalker added this to the 2.14.0 milestone Oct 14, 2020
@laurenwalker laurenwalker modified the milestones: 2.14.0, 2.15.0 Nov 24, 2020
@laurenwalker laurenwalker removed this from the 2.15.0 milestone Apr 6, 2021
@jeanetteclark
Copy link
Collaborator

bump for this issue. A user just had a failed submission, and I cannot figure out how to contact them. If the email address field were required I would have already emailed them - instead I'm going to keep looking and/or hope they email us. Either way, I'm not having a good time, and I'm sure the user on the other end isn't either.

@laurenwalker
Copy link
Member

Ok, thanks for letting me know. I will take a look at this.

@mbjones
Copy link
Member

mbjones commented Oct 21, 2021

Reiterating my earlier comment (#545 (comment)), this might be really easy and require almost no UI changes on our part if we switch to using an ORCID login with a member account where we can require the email and name attributes.

@jeanetteclark
Copy link
Collaborator

Hi @laurenwalker - just giving this another bump!

laurenwalker added a commit that referenced this issue May 31, 2022
…. This will enable requiring email addresses to complete #545
@laurenwalker
Copy link
Member

I've implemented this feature in MetacatUI by adding the ability to require the Contact email in the editor. (other EMLParty fields can be required, too). I created an issue in the d1_portal_servlet repo to get the email from the ORCID API when users login: DataONEorg/d1_portal_servlet#3

@laurenwalker
Copy link
Member

It is my understanding from the ORCID API documentation that we can request the email from users when they login via ORCID, but we cannot require it since it is part of the ORCID Trusted Data. So we cannot rely on the ORCID API implementation as a way to require email addresses for each submission. However, I still think it will be useful to try to get that info upon login anyway.

@laurenwalker laurenwalker added this to the 2.21.0 milestone Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants