Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the ProjectSectionView #815

Closed
csjx opened this issue Oct 31, 2018 · 2 comments
Closed

Implement the ProjectSectionView #815

csjx opened this issue Oct 31, 2018 · 2 comments

Comments

@csjx
Copy link
Member

csjx commented Oct 31, 2018

A Project Section is a generic section view with a TOCView and a MarkdownView as subviews. Create this view with its subviews.

This is a subtask of DataONEorg/collections-portals-schemas#35

csjx added a commit that referenced this issue Oct 31, 2018
Add the ProjectSectionView view with stubbed out methods. This view represents a generic tabbed section in the project view.

refs #815
jkibele added a commit that referenced this issue Nov 15, 2018
… views.

This was looking a bit closer to the wireframes before Lauren's changes to the css, but it still serves. There's currently just a single tab representing a project section. ...and it's an instance of project section. The next step is to replace that instance with project home, people, metrics, and visualizations that sub class project section view. DataONEorg/collections-portals-schemas#35 #824 #815
robyngit added a commit that referenced this issue Nov 21, 2018
…View

This is the first step in setting up the markdown view. The next step is using showdown to convert the markdown to HTML. I added a listener to projectView so that the subviews render after the model syncs, since information from the model is required for all the subviews. This causes a delay before the subviews are rendered, so perhaps there is a better way to achieve this. I added all the subviews to the subviews array and used _.invoke to have them all render.

refs #815, #820
laurenwalker added a commit that referenced this issue Nov 27, 2018
…ct.html template instead. The tabs are now just written in the template rather than created by each section view.

Pass the label and description to the ProjectHeaderView
Stubbed out the DataCatalogView rendering in the ProjectHomeView
Simplified the HTML in the overall project template and added the
necessary Bootstrap classes to make the tabs work.
Related to #829, #816
Closes #815
@laurenwalker
Copy link
Member

I believe this is done now.

I reworked how the tabs are done in the views in the latest commit - 49eedc3

The tabs were originally being rendered by each ProjectSectionView. But the tab elements will not be contained within each section view. They will be in the navigation bar outside of each section, just below the header. Each view should only render and manipulate elements that are inside the view el.

So I moved the tabs to the project.html template. Each section view is agnostic to the navigation outside of it (i.e. the section views don't know that tabs or other links to it exist).

@laurenwalker
Copy link
Member

Oh, also, the tab links work now because I added the necessary Bootstrap classes as seen here - http://getbootstrap.com/2.3.2/components.html#navs

@laurenwalker laurenwalker added this to the 2.6.0 milestone Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants