Map Components Polish 1: Toolbar links tweaks #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes tweaks to badge, settings toggle and legend.
The changes should only apply to elements within the panel. Moving the panel from overlay to right hand side will be in a different PR.
ianguerin
approved these changes
Apr 10, 2024
robyngit
requested changes
Apr 11, 2024
Closed
Robyn noticed a map sizing issue on ADC because I was confused by the sizing variable names and did the calculation wrong. Renamed variables to make it clearer and fixed the calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Light before and after:
Dark before and after: