PR to test auto changing target branch from main to develop #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove References to Morpho (and change contact email)
- Initial prettier setup; do not format yet - Fix syntax errors in files that would prevent prettier from formatting them Issue #2096
- Initial prettier formatting run Issue #2096
globally defined packages are specified in eslint config Issue #2096
Add a MapAssets collection to maintain a list of layers in a Map model
…-panel-layer-cats Feature 2419 use shared expansion panel layer categories view
1. Replace current blue- and grey- color variables with primary- and neutral- 2. Remove all semantic color variables I created in the light theme update. Replace them with the primary- and neutral- variables that they reference. This PR is a part of the plan for new color system. design doc in progress: https://docs.google.com/document/d/1Eb0uixayVeEgO0AcIEjDO6J5555A_CA1BK0nZp1s-uk/edit?usp=sharing We're doing this refactoring first because it will make the legend work a lot simpler.
This container is intended to be a parent for the map and all overlays (ex. legend, scale bar, etc).
To make lint happy
...to MapWidgetContainerView. This is so that this container can be reusable in the future if we swap out the underlying map framework.
1. Replace current blue- and grey- color variables with primary- and neutral- 2. Remove all semantic color variables I created in the light theme update. Replace them with the primary- and neutral- variables that they reference. This PR is a part of the plan for new color system. design doc in progress: https://docs.google.com/document/d/1Eb0uixayVeEgO0AcIEjDO6J5555A_CA1BK0nZp1s-uk/edit?usp=sharing We're doing this refactoring first because it will make the legend work a lot simpler.
…iner Legend 1: Create Cesium widget container
Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
These scoped type names are used inconsistently throughout the code base and violate lint rules. I will not attempt a fix in this PR, and hold off until we have an agreed upon approach.
…mponents Legend 2: Create legend components
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
To trigger action based on PR's head branch name instead base branch name, must use the github.head_ref context in a conditional. The branches property applies only to base branch. Issue #2456
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| /** @lends MapModel.prototype */ { | ||
| /** | ||
| * Configuration options for a {@link MapModel} that control the | ||
| * appearance of the map, the data/imagery displayed, and which UI | ||
| * components are rendered. A MapConfig object can be used when | ||
| * initializing a Map model, e.g. `new Map(myMapConfig)` | ||
| * @namespace {Object} MapConfig | ||
| * @namespace {object} MapConfig | ||
| * @property {MapConfig#CameraPosition} [homePosition] - A set of |
There was a problem hiding this comment.
Syntax error in type: MapConfig#CameraPosition
| @@ -68,6 +77,8 @@ | |||
| * viewfinder UI and viewfinder button in the toolbar. The ViewfinderView | |||
| * requires a Google Maps API key present in the AppModel. In order to | |||
| * work properly the Geocoding API and Places API must be enabled. | |||
| * requires a Google Maps API key present in the AppModel. In order to | |||
| * work properly the Geocoding API and Places API must be enabled. | |||
| * @property {Boolean} [toolbarOpen=false] - Whether or not the toolbar is | |||
There was a problem hiding this comment.
Invalid JSDoc @Property "toolbarOpen" type "Boolean"; prefer: "boolean".
reviewdog suggestion error
GitHub comment range and suggestion line range must be same. L82-L82 v.s. L42-L68| @@ -95,6 +106,7 @@ | |||
| * predefined list of locations with an enabled list of layer IDs to be | |||
There was a problem hiding this comment.
Expected no lines between tags
reviewdog suggestion error
GitHub comment range and suggestion line range must be same. L106-L106 v.s. L42-L110| @@ -295,6 +312,7 @@ | |||
| this.setUpInteractions(); | |||
| } catch (error) { | |||
| console.log("Failed to initialize a Map model.", error); | |||
There was a problem hiding this comment.
Unexpected console statement.
| @@ -295,6 +312,7 @@ | |||
| this.setUpInteractions(); | |||
| } catch (error) { | |||
| console.log("Failed to initialize a Map model.", error); | |||
| console.log("Failed to initialize a Map model.", error); | |||
There was a problem hiding this comment.
Unexpected console statement.
| @@ -318,61 +311,54 @@ | |||
| * @param {MapConfig#MapAssetConfig} [assetConfig] The initial values of the | |||
There was a problem hiding this comment.
Syntax error in type: MapConfig#MapAssetConfig
| @@ -642,33 +615,22 @@ | |||
| * @since 2.19.0 | |||
| * @param {MapConfig#CustomDateProperty} config - An object that defines the new | |||
There was a problem hiding this comment.
Syntax error in type: MapConfig#CustomDateProperty
| @@ -680,29 +642,15 @@ | |||
| * @since 2.19.0 | |||
| * @param {MapConfig#CustomStringProperty} config The object the defines the new | |||
There was a problem hiding this comment.
Syntax error in type: MapConfig#CustomStringProperty
| @@ -786,51 +734,46 @@ | |||
| /** | |||
| * Given properties of a Feature model from this MapAsset, returns the color | |||
| * associated with that feature. | |||
| * @param {Object} properties The properties of the feature to get the color for; | |||
| * @param {object} properties The properties of the feature to get the color for; | |||
| * An object containing key-value mapping of property names to properties. (See | |||
| * the 'properties' attribute of {@link Feature#defaults}.) | |||
| * @returns {AssetColor#Color} The color associated with the given set of | |||
There was a problem hiding this comment.
Syntax error in type: AssetColor#Color
| * this MapAsset. | ||
| * @param {Feature} feature The feature to navigate to. | ||
| * @param {MapConfig#CameraPosition} target The target to navigate to. |
There was a problem hiding this comment.
Syntax error in type: MapConfig#CameraPosition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch to test the new GitHub action introduced in #2457.
I am opening this draft PR with
mainas the base branch. I expect the action to switch it todevelop.