Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate CRAVAT error #126

Open
gianfilippo opened this issue Sep 10, 2023 · 18 comments
Open

Annotate CRAVAT error #126

gianfilippo opened this issue Sep 10, 2023 · 18 comments

Comments

@gianfilippo
Copy link

Hi,

I am running the latest version of your pipeline (3.3.1) and it got stuck in a couple of occasions.
The most relevant, for the moment, is the Annotate CRAVAT, since cravat is reporting an error related to an erroneous option used (see below).

How can I fix it ?

Thanks

[First 3000 bytes]:+ echo '########### Annotate CRAVAT #############'

  • cravat_lib_dir=/home/project/scripts/GRCh38_gencode_v37_CTAT_lib_Mar012021.plug-n-play/ctat_genome_lib_build_dir/ctat_mutation_lib/cravat
  • '[' /home/project/scripts/GRCh38_gencode_v37_CTAT_lib_Mar012021.plug-n-play/ctat_genome_lib_build_dir/ctat_mutation_lib/cravat == '' ']'
  • export TMPDIR=/tmp
  • TMPDIR=/tmp
  • /home/project/scripts/ctat-mutations-CTAT-Mutations-v3.3.1/src/annotate_with_cravat.py --input_vcf /home/project/scripts/MC01N/cromwell-executions/ctat_mutations/e9895a07-0b11-4196-9113-83dacb214059/call-AnnotateVariants/annotate_variants_wf/6f770036-3c25-4615-b15e-382002860a9d/call-open_cravat/inputs/559431456/MC01N.annot_cosmic.vcf.gz --genome hg38 --cravat_lib_dir /home/project/scripts/GRCh38_gencode_v37_CTAT_lib_Mar012021.plug-n-play/ctat_genome_lib_build_dir/ctat_mutation_lib/cravat --output_vcf MC01N.cravat.tmp.vcf
    usage: oc run [-h] [-a ANNOTATORS [ANNOTATORS ...]]
    [-e EXCLUDES [EXCLUDES ...]] [-n RUN_NAME] [-d OUTPUT_DIR]
    [--startat {converter,mapper,annotator,aggregator,postaggregator,reporter}]
    [--endat {converter,mapper,annotator,aggregator,postaggregator,reporter}]
    [--skip {converter,mapper,annotator,aggregator,postaggregator,reporter} [{converter,mapper,annotator,aggregator,postaggregator,reporter} ...]]
    [-c CONF] [--cs CONFS] [-v] [-t {excel,text} [{excel,text} ...]]
    [-l {hg38,hg19,hg18}] [-x] [--newlog] [--note NOTE] [--mp MP]
    [-i {cravat,oldcravat,vcf}] [--temp-files] [--writeadmindb]
    [--jobid JOBID] [--version] [--separatesample]
    [--primary-transcript [PRIMARY_TRANSCRIPT [PRIMARY_TRANSCRIPT ...]]]
    [--cleanrun] [--do-not-change-status]
    [--module-option [MODULE_OPTION [MODULE_OPTION ...]]]
    [--system-option [SYSTEM_OPTION [SYSTEM_OPTION ...]]] [--silent]
    [inputs [inputs ...]]
    oc run: error: argument -t: invalid choice: 'vcf' (choose from 'excel', 'text')

CMD: annotate_with_cravat: oc run /home/project/scripts/MC01N/cromwell-executions/ctat_mutations/e9895a07-0b11-4196-9113-83dacb214059/call-AnnotateVariants/annotate_variants_wf/6f770036-3c25-4615-b15e-382002860a9d/call-open_cravat/inputs/559431456/MC01N.annot_cosmic.vcf.gz --module-option vcfreporter.type=separate --system-option modules_dir=/home/project/scripts/GRCh38_gencode_v37_CTAT_lib_Mar012021.plug-n-play/ctat_genome_lib_build_dir/ctat_mutation_lib/cravat -t vcf -l hg38 -d -n MC01N.cravat.tmp

@brianjohnhaas
Copy link
Collaborator

brianjohnhaas commented Sep 10, 2023 via email

@gianfilippo
Copy link
Author

Hi,

yes, I forgot to mention that I am running the singularity version.
I followed the steps described here https://github.com/NCIP/ctat-mutations/wiki/CTAT-mutations-installation
including Step 4 to install Open-CRAVAT 2.0.1

I should add that I had to also download the github CTAT-Mutations-v3.3.1 source code, since the ctat-mutation-lib-integration.py is missing, otherwise.

I believe the Open-CRAVAT package was missing from the singularity image

@brianjohnhaas
Copy link
Collaborator

brianjohnhaas commented Sep 10, 2023 via email

@gianfilippo
Copy link
Author

gianfilippo commented Sep 10, 2023 via email

@brianjohnhaas
Copy link
Collaborator

brianjohnhaas commented Sep 10, 2023 via email

@brianjohnhaas
Copy link
Collaborator

brianjohnhaas commented Sep 10, 2023 via email

@gianfilippo
Copy link
Author

gianfilippo commented Sep 10, 2023

Hi,

thanks for updating the documentation.

Unfortunately, I still get the error. Just to clarify, I did not install open-cravat directly onto the system, rather I created a conda environment for it.
I reran the pipeline using the provided test FASTQ files, without activating the open-cravat, to make sure it would run the provided version. Still, I get the same error

oc run: error: argument -t: invalid choice: 'vcf' (choose from 'excel', 'text')

I then edited the annotate_with_cravat.py under. ctat-mutations-CTAT-Mutations-v3.3.1/src and replaced 'vcf' with 'text' under the '-t' option. Now the open-cravat did not produce any error, but the following step fails (see below)

CMD: annotate_with_cravat: oc run /home/project/scripts/MC01N/cromwell-executions/ctat_mutations/da88d4de-483f-4832-a617-3d6ce8c742df/call-AnnotateVariants/annotate_variants_wf/dd4ace68-921a-484f-a695-37bb85cb5fb1/call-open_cravat/inputs/747081951/MC01N.annot_cosmic.vcf.gz --module-option vcfreporter.type=separate --system-option modules_dir=/home/project/scripts/GRCh38_gencode_v37_CTAT_lib_Mar012021.plug-n-play/ctat_genome_lib_build_dir/ctat_mutation_lib/cravat -t text -l hg38 -d -n MC01N.cravat.tmp

  • /home/project/scripts/ctat-mutations-CTAT-Mutations-v3.3.1/src/groom_vcf.py MC01N.cravat.tmp.vcf MC01N.cravat.groom.vcf
    Traceback (most recent call last):
    File "/home/project/scripts/ctat-mutations-CTAT-Mutations-v3.3.1/src/groom_vcf.py", line 43, in
    with ctat_util.open_file_for_reading(args.str_input_file) as hndl_vcf:
    File "/home/project/scripts/ctat-mutations-CTAT-Mutations-v3.3.1/src/ctat_util.py", line 10, in open_file_for_reading
    return open(filename, 'rt', encoding="utf-8", errors='ignore') # regular text file
    FileNotFoundError: [Errno 2] No such file or directory: 'MC01N.cravat.tmp.vcf'

[2023-09-10 17:24:35,55] [info] WorkflowManagerActor WorkflowActor-da88d4de-483f-4832-a617-3d6ce8c742df is in a terminal state: WorkflowFailedState

@brianjohnhaas
Copy link
Collaborator

brianjohnhaas commented Sep 10, 2023 via email

@gianfilippo
Copy link
Author

Hi,

I just ran the "make HC_standard_singularity" command under testing and got the same error. Somehow it is running a version of open-cravat that does not support the "vcf" entri for the "-t" option.

I will probably try the manual install, since Docker does not run on my cluster.

Can you please let me know what version of numpy you packaged with the singularity image file ?

Thanks

@brianjohnhaas
Copy link
Collaborator

brianjohnhaas commented Sep 11, 2023 via email

@gianfilippo
Copy link
Author

Hi,

I did some more tests and reinstalled open-cravat 2.0.1 under a conda env CTAT I created. I can run oc and the version is confirmed to be 2.0.1
oc run --version
2.0.1

I then ran the oc CMD directly (from the log file reporting the error)
oc run MC01N/cromwell-executions/ctat_mutations/785846d3-5ab1-4930-9b61-cff25eead75f/call-AnnotateVariants/annotate_variants_wf/8a9fc0bb-6c99-4320-a995-4c7522549aeb/call-open_cravat/inputs/-1303126155/MC01N.annot_cosmic.vcf.gz --module-option vcfreporter.type=separate --system-option modules_dir=GRCh38_gencode_v37_CTAT_lib_Mar012021.plug-n-play/ctat_genome_lib_build_dir/ctat_mutation_lib/cravat -t vcf -l hg38 -d -n MC01N.cravat.tmp

I still get the error: argument -t: invalid choice: 'vcf (see below).
usage: oc run [-h] [-a ANNOTATORS [ANNOTATORS ...]] [-e EXCLUDES [EXCLUDES ...]] [-n RUN_NAME] [-d OUTPUT_DIR]
[--startat {converter,mapper,annotator,aggregator,postaggregator,reporter}] [--endat {converter,mapper,annotator,aggregator,postaggregator,reporter}]
[--skip {converter,mapper,annotator,aggregator,postaggregator,reporter} [{converter,mapper,annotator,aggregator,postaggregator,reporter} ...]] [-c CONF] [--cs CONFS]
[-v] [-t {text,excel} [{text,excel} ...]] [-l {hg38,hg19,hg18}] [-x] [--newlog] [--note NOTE] [--mp MP] [-i {cravat,oldcravat,vcf}] [--temp-files] [--writeadmindb]
[--jobid JOBID] [--version] [--separatesample] [--primary-transcript [PRIMARY_TRANSCRIPT [PRIMARY_TRANSCRIPT ...]]] [--cleanrun] [--do-not-change-status]
[--module-option [MODULE_OPTION [MODULE_OPTION ...]]] [--system-option [SYSTEM_OPTION [SYSTEM_OPTION ...]]] [--silent]
[inputs [inputs ...]]
oc run: error: argument -t: invalid choice: 'vcf' (choose from 'text', 'excel')

I am a little lost at this point.....

@brianjohnhaas
Copy link
Collaborator

brianjohnhaas commented Sep 19, 2023 via email

@gianfilippo
Copy link
Author

Hi,

I am sorry, but I am getting the same error
"oc run: error: argument -t: invalid choice: 'vcf' (choose from 'text', 'excel')"

I also tried by manually entering the command.

The oc version is 2.1.0 and the "-t" input format is the same as the latest version, so probably you wrote the script for a version earlier than 2.0.1, since that did not work either for me.

Can you not update the python script to use the newer input to the -t argument ?

Best

@gianfilippo
Copy link
Author

I installed oc version 2.0.0 and the -t argument input is probably consistent with your script.

@brianjohnhaas
Copy link
Collaborator

brianjohnhaas commented Sep 19, 2023 via email

@gianfilippo
Copy link
Author

I am really referring to the annotate_with_cravat.py script, under ctat-mutations-v4.0.0/src/
In there you define the oc input arguments, including "-t".
Can you not package the singularity image with oc 2.0.0 ?

@brianjohnhaas
Copy link
Collaborator

brianjohnhaas commented Sep 20, 2023 via email

@gianfilippo
Copy link
Author

gianfilippo commented Sep 20, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants