Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"No Tree Conditions" red bar is now showing up on all living trees without tree conditions selected #64

Closed
lizmatthews03 opened this issue Jun 6, 2018 · 3 comments
Closed

"No Tree Conditions" red bar is now showing up on all living trees without tree conditions selected #64

lizmatthews03 opened this issue Jun 6, 2018 · 3 comments
Assignees
@blcampbell
Labels
bug Functionality does not work as designed Event Report Groups Event Report related issues P2 - High Priority 2 - Issue is a high priority to resolve
Milestone
2019 Pre-Season U...

Comments

@lizmatthews03
Copy link

After one of the recent DB updates, the "No Tree Conditions" red banner on the Event Report is now showing up on many tree that it previously did not. It now shows up for living trees with the V-C-F check boxes complete. Having no tree conditions is not an error, if the boxes are checked.

This red banner was previously working correctly for living trees, so I'm not sure what changed.

I have example Event Reports (from the same plot, but printed at different times-- an therefore using different version of the DB) that illustrate the issue...
@lizmatthews03 lizmatthews03 added bug Functionality does not work as designed P2 - High Priority 2 - Issue is a high priority to resolve Event Report Groups Event Report related issues labels Jun 6, 2018
@blcampbell blcampbell self-assigned this Jun 21, 2018
@blcampbell blcampbell added this to the 2019 Pre-Season Updates milestone Oct 24, 2018
@blcampbell
Copy link
Contributor

@johnpauls or @abrolis please confirm this is what we should see for alive & dead per @lizmatthews03 comments above:

image

In this case no live trees have the red bar as those w/o tree conditions have V-C-F checkboxes checked.
Should there be an instance where one of the V-C-F checkboxes was unchecked for a live tree and no tree conditions were noted (listed), that would display the NO TREE CONDITIONS in red.

@abrolis
Copy link

abrolis commented Oct 24, 2018

If a tree is alive we should always have those three boxes checked if we've collected all the data. For dead individuals, the only time we would not leave all the boxes un-checked is if there was a condition of EAB. Other than that, everything looks good to me.

@johnpauls
Copy link
Member

@blcampbell , @abrolis

The sample above is what I would expect to see. If any of the V C F boxes is unchecked, then there should be a big red bar indicating that happened, regardless of what conditions have been listed. Perhaps the text could be "Vines, Conditions or Foliar Conditions Missing" or something similar.

blcampbell pushed a commit that referenced this issue Apr 21, 2021
v9.8.0.9005 - incremental release
7e60ead 
Version 9.8.0.9005
2021 Pre-Season Updates
Incremental release addresses the following…

**Export issues**
Closes #9(Prevent RFS tag exports)
Closes #16(Browse data not exported for herbaceous species)
Closes #18(DBH/basal area not exported for dead trees)
Closes #76(Saplings w/o habit excluded)
Closes #77(Include DBH double-checked? w/ @ DBH record)
Closes #80(Export DBH double checked In tree/sapling CSVs)
Closes #83(Add comments)
Closes #90(Add state/county to plots export)
Closes #105(Trees w/o azimuth/distance not exported)
Closes #107(Tree/sapling vigor not exported)
Closes #138(CWD exports incorrectly)
Closes #201 (Export function does not work)
Closes #216(Change UnitCode to Unit_Code)
Closes #217(Duplicate records for synonyms)
Closes #220(Add and expose plant species export field)
Closes #221(Add tlu_Plants Export field)
Closes #222(Export species lists)

**Event Report issues**
Closes #3 (Identify trees surpassing threshold)
Closes #20(Equivalent DBH should display)
Closes #63(Report doesn't open from gateway form)
Closes #64(No Tree Conditions red bar appears on all living trees w/o tree conditions selected)
Closes #65(Sapling foliar conditions don't show)
Closes #72(Sapling foliar issues not showing)
Closes #75(Missing tree/sapling/shrub ID doesn't highlight)
Fixes #112(Number appears at top)
Fixes #113(Not showing trees)
Closes #157(Sapling VCF checkboxes not showing)
Closes #158(Missing sapling DBHs not highlighted)
Closes #174(Monster saplings because of dead standing DBH)
Closes #178(Remove RIO from unsampled tags & event report)
Closes #184(Highlight herbaceous species cover < 0%)
Closes #197(Prior DBH's not correct)
Closes #294(Add stem prior DBHs)

**Import Issues**
Fixes #127(Quadrat data doesn't import)
Closes #139(Only 1 event imports per day)
Fixes #140(Secondary events from pseudoevents not imported)
Fixes #199 (Issue w/ importing tables from field data)

**Species Issues**
Closes #99(Add Berberis bealei to plants)
Closes #219(Add Parthenocissus tricuspidata)


**Data Issues**
Closes #66(Update tag status for all dead fall trees)
Closes #71(Delete MONO-0026 tag 99999)
Fixes #74(Move 2 trees from PRWI-0082 to PRWI-0028)
Closes #95(Retag 3593 to 25278)
Closes #96(Issues w/ tag 3250)
Fixes #89(Extra event)
Closes #223(Synonyms - change to new TSN_Accepted)
Closes #224(Synonyms - split out distinct species)
Closes #225(Synonyms - add new species as new default TSN_Accepted)

**General issues**
Closes #12(Add new plot data to locations table)
Closes #21(Deleted issue)
Closes #44(Species pad allow double click selection)
Closes #68(Vigor data field highlighted after crown class entry)
Closes #69(Target herb percent cover autofills to 0 after taxon entry)
Closes #70(Add quick comment "old primary branch broken")
Closes #78(Display all vs active tags)
Closes #85(Handle pseudo-events)
Closes #87(Sort tag history by date)
Closes #88(Add change log functionality to browse tag form)
Closes #91(Sapling tag status doesn’t update)
Closes #92(Pseudoevent - conversion to actual event)
Closes #103(Automatically update "habit" for saplings/shrubs based on species ID)
Closes #106(Preserve pseudo-event date)
Closes #111(Add tree/sapling/shrub condition for stress related to vines)
Closes #114(Tags not shifting to sampled on events form)
Closes #115(DBH double checked background remains)
Closes #120(RIO tags show at top of dropdown)
Closes #121(Targeted herbs % autofills to 0 w/ species selection)
Closes #122(Minimum 1.0 sapling DBH frequenlly pops up)
Closes #123(Add Show/Hide for trees we won't sample in unsampled tag dropdown)
Closes #124(Add buttons to browse plants/tags from events form)
Fixes #126(Lookup code for spotted lanternfly missing)
Closes #128(Sampled tag dropdown missing tree/sapling status)
Closes #136(Highlight when tag RFS flag set)
Closes #145(Post-Season review - RIO tags)
Closes #146(Event date(s) need to be updated)
Closes #156(Drop-down comments for change log not populating for azimuth/distance)
Closes #166(Shrinking DBHs not flagged)
Closes #171(64-bit conversion)
Closes #172(Integrate framework modules)
Closes #176(Herbaceous species w/o % cover or browse)
Closes #196(Cannot input multiple DBH measurements for multi-stemmed sapling)
Closes #198 (Unexpected popup when inputting living status for saplings)
Fixes #200 (Cannot create Db backup)
Fixes #202 (PriorDBH Incorrect)
Closes #203 (Add PriorDBH to tree/sapling Forms)
Fixes #205 (Advanced Data Summary - Event Summary report displays overlain text)
Fixes #207(New Event triggers null error for DBH)
Fixes #208(Unable to create new event)

Partially addresses (these are not fully exposed/implemented)
#100 (Add taxonomic reference adjustments)
#181 (Event Report - tree/sapling vine loss)
#186 (Allow event date changes)
#187 (Add measurement data flags set/edit/delete)
#188 (Add SOP version tracking)
#189(Add data flag utilities)
#192(Add event DPL utilities)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blcampbell blcampbell

Labels
bug Functionality does not work as designed Event Report Groups Event Report related issues P2 - High Priority 2 - Issue is a high priority to resolve
Projects
None yet
Milestone
2019 Pre-Season Updates
Development

No branches or pull requests
4 participants
@johnpauls @lizmatthews03 @blcampbell @abrolis