Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annona - Accessibility - Buttons must have discernible text #53

Closed
uom-mde opened this issue Feb 27, 2023 · 5 comments
Closed

Annona - Accessibility - Buttons must have discernible text #53

uom-mde opened this issue Feb 27, 2023 · 5 comments

Comments

@uom-mde
Copy link

uom-mde commented Feb 27, 2023

Hello all,

Firstly, many thanks for making this superb feature available- we've used it extensively in our latest online exhibition:
https://www.digitalexhibitions.manchester.ac.uk/s/qing/

While running accessibility checks on our site, they return a 'Buttons do not have an accessible name' flag. Is this something that can be addressed?

Best wishes,
John

@dnoneill
Copy link
Collaborator

dnoneill commented Feb 27, 2023

Hi John,
Based on this link it looks like you are using Exhibit. Are you sure you are using Annona? Even if you aren't using Annona I will be making this update, I just want to make sure your site actually has the accessibility updates you need.

Niqui

@uom-mde
Copy link
Author

uom-mde commented Feb 28, 2023

Hi Niqui,

Many thanks for your swift response, and for offering to make these changes. Apologies for confusing matters and not linking directly to a page using Annona: we have used both Exhibit.so and Annona, with Exhibit featuring on the home page, and Annona on the majority of others.

For example, you can find Annona used on this page:
https://www.digitalexhibitions.manchester.ac.uk/s/qing/page/knowledge-exchange

Best wishes,
John

@dnoneill
Copy link
Collaborator

Hi John,
I updated the toolbar so there should be an aria label that tells the user what each button does. I ran the WAVE extension on Annona before releasing it. I am wondering what you use for accessibility because it seems more robust. Please let me know if the latest update doesn't fix the problem. Also please let me know if there is anything else I can do to help. I love how you are using Annona.

Niqui

@uom-mde
Copy link
Author

uom-mde commented Mar 1, 2023

Hi Niqui,

Thanks for getting back to me, and for implementing that fix in double-quick time! I downloaded the core files again, generated a new 'dist' folder, and the aria labels are now present when running Annona according to the accessibility checkers.

For reference I use Google's Lighthouse tool, which can be added to Chrome as an extension. (I think it might be available by default within their developer tools, but can't confirm for certain....)

Thanks again for your/your team's great work on this feature- it's really appreciated- and your kind words on how we're applying it on our site. Should I note anything else I'll be in touch!

Best wishes,
John

@dnoneill
Copy link
Collaborator

dnoneill commented Mar 1, 2023

John,
Thank for getting back to me. I am going to go ahead and close this issue. Glad you reached out. I am hoping if it is okay with you to put your site on our in the wild section: https://ncsu-libraries.github.io/annona/examples/. Have a nice day.

Niqui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants