Pass quick_search_config.yml file through ERB processor #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quick_search_config.yml file contains some properties that might differ on a dev server vs. a production server. For example, the Best Bets "solr_url" property might point to a dev Solr instance from a dev server, and a production Solr instance on a production server. Is it often convenient to provide such information via environment variables that are passed into Rails. This pull request modifies the processing of the config/quick_search_config.yml file to pass it through the ERB template processor. ERB directives such as "<%= ENV['SOLR_URL'] %>" can then be added to the file, to enable environment variables to be utilized.
|
Looks good to me. We've been using this approach in some of our more recent Rails applications too. Thanks for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quick_search_config.yml file contains some properties that
might differ on a dev server vs. a production server. For example,
the Best Bets "solr_url" property might point to a dev Solr instance
from a dev server, and a production Solr instance on a production
server.
Is it often convenient to provide such information via environment
variables that are passed into Rails. This pull request modifies
the processing of the config/quick_search_config.yml file to pass
it through the ERB template processor. ERB directives such as
"<%= ENV['SOLR_URL'] %>" can then be added to the file, to enable
environment variables to be utilized.