Arenaform new design #2020
Merged
Arenaform new design #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonas-C
reviewed
Sep 10, 2024
| condition?: boolean, | ||
| ) => { | ||
| if (!condition && isActive) { | ||
| return setToolbarValues((prev) => [...prev.filter((val) => val !== format)]); |
There was a problem hiding this comment.
Hvorfor trenger vi å spreade her?
| if (!condition && isActive) { | ||
| return setToolbarValues((prev) => [...prev.filter((val) => val !== format)]); | ||
| } else if (condition && !isActive) { | ||
| return setToolbarValues((prev) => [...prev, format]); |
There was a problem hiding this comment.
Dette kan vel bare være en concat?
| @@ -69,18 +71,34 @@ interface EditorToolbarProps { | |||
| editorIsFocused: boolean; | |||
| } | |||
|
|
|||
| const selectionHasFormat = ( | |||
There was a problem hiding this comment.
Synes ikke navnet på denne funksjonen reflekterer det som faktisk skjer i den.
| setIsNumberedList(type === "number"); | ||
|
|
||
| if (type === "bullet") { | ||
| return !isUnorderedList && setToolbarValues((prev) => [...prev.filter(filterList), "unordered"]); |
| if (type === "bullet") { | ||
| return !isUnorderedList && setToolbarValues((prev) => [...prev.filter(filterList), "unordered"]); | ||
| } else { | ||
| return !isOrderedList && setToolbarValues((prev) => [...prev.filter(filterList), "ordered"]); |
There was a problem hiding this comment.
Trenger dette å være en spread?
There was a problem hiding this comment.
Ser ut som at vi nester P i P her. Sjekk content
| @@ -184,9 +171,10 @@ const ArenaForm = ({ onSave, onAbort, type, initialTitle, initialContent, initia | |||
| shouldDirty: true, | |||
| }); | |||
| }} | |||
| initialValue={initialContent ?? ""} | |||
| initialValue={initialContent ?? "<p></p>"} | |||
There was a problem hiding this comment.
Hvorfor er det endring her?
Jonas-C
reviewed
Sep 12, 2024
Comment on lines
62
to
69
| const ButtonRow = styled(HStack, { | ||
| base: { | ||
| width: "100%", | ||
| "& > button": { | ||
| flexGrow: "1", | ||
| }, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Her tror jeg vi kan forenkle litt, faktisk. Hva med å gjøre det til en grid som har 1fr 1fr? Da kan vi droppe stack og flexGrow
Jonas-C
reviewed
Sep 12, 2024
| onClick={insertLink} | ||
| aria-label={linkLabel} | ||
| title={linkLabel} | ||
| aria-selected={isLink} |
There was a problem hiding this comment.
Vi trenger vel ikke aria-selected?
Jonas-C
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nytt design på arenaform.