Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename 404 text #45

Merged
merged 3 commits into from
Mar 14, 2022
Merged

fix: rename 404 text #45

merged 3 commits into from
Mar 14, 2022

Conversation

norrec99
Copy link
Contributor

@norrec99 norrec99 commented Mar 8, 2022

#42 (comment)
I used capital letters for the replacement of "404" text

Here how it looks
image

And this is the lower case "Error" message
image

I think the first one looks better but I can change according to your liking

@ryancwalsh
Copy link
Contributor

@norrec99 Of those 2, I prefer the second one ("Error"). But I'd also be curious to see a version where you remove "Error" (and the gray vertical line) entirely.

@norrec99
Copy link
Contributor Author

It looks like that:

image

@ryancwalsh
Copy link
Contributor

@norrec99 Cool, I like that version (#45 (comment)) the best.

@ryancwalsh ryancwalsh merged commit 2a6f28f into develop Mar 14, 2022
@ryancwalsh ryancwalsh deleted the fix/custom-404 branch March 14, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants