Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds feedback and fixes an init #51

Merged
merged 6 commits into from
Mar 6, 2024
Merged

Adds feedback and fixes an init #51

merged 6 commits into from
Mar 6, 2024

Conversation

elliotBraem
Copy link
Contributor

@elliotBraem elliotBraem commented Jan 23, 2024

Feedback:

See an app that I initialized to test bos-workspace here: https://github.com/NEARBuilders/buildbox/tree/bw-wip

I really like the new alias pattern -- alias/name, config/account, module/hello.
The testnet override is much needed atm, glad to see it.

High Priority

  • build after testing throws tsc error
  • init without project name throws error "[path] argument is required"
  • home doesn't run because "hello" is not a function (need to default VM.require, fix in "init")
  • newly initialized typescript files are throwing errors, we need to include package.json, eslint, tsconfig, etc... (open to choose typescript or javascript) in the init
  • I think module/hello should match: module.hello rather than hello.module (or we should remove this pattern)
  • I think the output should be /build, rather than in .bos; although maybe something like bos-loader.json should stay in .bos
  • It's not reading nested widgets (widget/page/home is not building or resolving from bosworkspace/widget/page.home)

Lower Priority

  • socket connects and disconnects, why?
  • how could bw init be configured with template repositories rather than static files?
  • We could prompt the account name during bw init
  • Idk what error, but hot-reload was killed once during editing (exception handling)

We'll also need to implement Mattb's recent change for clone, pull, delete

@elliotBraem elliotBraem merged commit c4f3709 into 1.0.0.wip Mar 6, 2024
@elliotBraem elliotBraem deleted the review/1.0.0.wip branch March 6, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant