Percent encode reserved characters #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theon
added a commit
that referenced
this pull request
Dec 20, 2012
Percent encode reserved characters
|
Thanks for the contribution. I've merged it in. I've also committed some changes to use a custom percent encoding algorithm rather than anything JDK provided to allow customised encoding, for example, encoding spaces as pluses This has been published to the OSS Sontaype repo: https://oss.sonatype.org/content/groups/public/com/github/theon/scala-uri_2.9.2/0.2-SNAPSHOT/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple patch to percent encode all reserved characters using UTF-8 encoding. This fixes the immediate issue raised in #2, but probably needs to be made more configurable as per comments on that issue.