Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: codebox): fix show code window back title always show '返回' #35

Merged
merged 3 commits into from
Oct 12, 2018

Conversation

Guoyuanqiang
Copy link
Member

feat(showcase: codebox): tooltip always show

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

fix(showcase: codebox): fix show code window back title always show '返回'

feat(showcase: codebox): tooltip always show
@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #35   +/-   ##
======================================
  Coverage    85.9%   85.9%           
======================================
  Files         209     209           
  Lines        6889    6889           
  Branches      977     977           
======================================
  Hits         5918    5918           
  Misses        559     559           
  Partials      412     412

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97639fc...5a2caa6. Read the comment docs.

Copy link
Contributor

@3fuyu 3fuyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please format your code

@Guoyuanqiang Guoyuanqiang merged commit 0720fdc into NG-ZORRO:master Oct 12, 2018
@Guoyuanqiang Guoyuanqiang deleted the guoyq-fix branch October 12, 2018 06:27
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
#35)

* fix(module: codebox): fix show code window back title always show '返回'

* fix(module:codebox): format code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants