Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:picker): fix return result error #462

Merged
merged 1 commit into from
Jun 3, 2019
Merged

fix(module:picker): fix return result error #462

merged 1 commit into from
Jun 3, 2019

Conversation

nuonuoge
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #462 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
- Coverage   85.64%   85.62%   -0.03%     
==========================================
  Files         270      270              
  Lines        7595     7597       +2     
  Branches     1086     1087       +1     
==========================================
  Hits         6505     6505              
- Misses        663      665       +2     
  Partials      427      427
Impacted Files Coverage Δ
components/picker/picker.component.ts 69% <0%> (-0.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413178d...81e7a17. Read the comment docs.

@Guoyuanqiang Guoyuanqiang merged commit eeabc11 into NG-ZORRO:master Jun 3, 2019
@nuonuoge nuonuoge deleted the fix-picker branch June 11, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants