Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: pull-to-refresh): fix pull-to-refresh not work bug & code refactor #573

Merged
merged 3 commits into from
Sep 6, 2019

Conversation

BronzeCui
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #573 into master will increase coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
+ Coverage   88.52%   88.58%   +0.05%     
==========================================
  Files         270      270              
  Lines        7601     7593       -8     
  Branches     1084     1082       -2     
==========================================
- Hits         6729     6726       -3     
+ Misses        428      425       -3     
+ Partials      444      442       -2
Impacted Files Coverage Δ
...nents/pull-to-refresh/pull-to-refresh.component.ts 73.88% <66.66%> (+1.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aa3149...c52bca9. Read the comment docs.

@fisherspy fisherspy merged commit 6df7d7c into NG-ZORRO:master Sep 6, 2019
@BronzeCui BronzeCui deleted the bronze-fix branch September 9, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants