feat(module:tree, tree-select): support customize icons #2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2933 +/- ##
==========================================
+ Coverage 97.38% 97.38% +<.01%
==========================================
Files 559 559
Lines 11634 11639 +5
Branches 835 835
==========================================
+ Hits 11330 11335 +5
Misses 193 193
Partials 111 111
Continue to review full report at Codecov.
|
|
Deploy preview for ng-zorro-master ready! Built with commit 076400e |
hsuanxyz
requested changes
Feb 27, 2019
hsuanxyz
changed the title
hsuanxyz
approved these changes
Feb 28, 2019
simplejason
reviewed
Mar 2, 2019
|
抽时间考虑一下string支持问题，如果支持要么取消旋转class，要么对用户说明旋转属于设计问题，之后rebase一下master |
|
@simplejason 移除了 string 的支持，新增了 show line 时也支持自定义图标。 |
wenqi73
reviewed
Mar 8, 2019
|
@hsuanxyz @simplejason 没其他问题的话，麻烦 merge 一下吧，不然隔段时间就要 rebase |
simplejason
reviewed
Apr 11, 2019
simplejason
approved these changes
Apr 15, 2019
3 tasks
andrew-yangy
pushed a commit
to andrew-yangy/ng-zorro-antd
that referenced
this pull request
Jun 20, 2019
* feat(module:tree and tree-select): customized icon * feat(module:tree and tree-select): add template context * feat(module:tree and tree-select): fix lint * feat(module:tree and tree-select): fix type * feat(module:tree and tree-select): support customize icons with show line * feat(module:tree and tree-select): fix test * feat(module:tree and tree-select): update doc * feat(module:tree and tree-select): fix quotation * feat(module:tree and tree-select): fix testing * feat(module:tree and tree-select): modify dome variable
wenqi73
reviewed
Jan 6, 2020
| [type]="node.isExpanded ? 'folder-open' : 'folder'" | ||
| class="ant-tree-switcher-line-icon" | ||
| ></i> | ||
| <i *ngIf="node.origin.isLeaf" nz-icon type="file" class="ant-tree-switcher-line-icon"></i> |
There was a problem hiding this comment.
@danranVm @simplejason demo 要改一下，nzExpandedIcon 就是 非叶子节点才有的。。会造成误解
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* feat(module:tree and tree-select): customized icon * feat(module:tree and tree-select): add template context * feat(module:tree and tree-select): fix lint * feat(module:tree and tree-select): fix type * feat(module:tree and tree-select): support customize icons with show line * feat(module:tree and tree-select): fix test * feat(module:tree and tree-select): update doc * feat(module:tree and tree-select): fix quotation * feat(module:tree and tree-select): fix testing * feat(module:tree and tree-select): modify dome variable
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* feat(module:tree and tree-select): customized icon * feat(module:tree and tree-select): add template context * feat(module:tree and tree-select): fix lint * feat(module:tree and tree-select): fix type * feat(module:tree and tree-select): support customize icons with show line * feat(module:tree and tree-select): fix test * feat(module:tree and tree-select): update doc * feat(module:tree and tree-select): fix quotation * feat(module:tree and tree-select): fix testing * feat(module:tree and tree-select): modify dome variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2890 #2503
What is the new behavior?
Does this PR introduce a breaking change?
Other information