Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:date-picker): support nzOnCalendarChange #3169

Merged

Conversation

kekehaoz
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1509

What is the new behavior?

date-picker will support onCalendarChange

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Mar 26, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 4d3cdb5

https://deploy-preview-3169--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #3169 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3169      +/-   ##
==========================================
+ Coverage   97.37%   97.38%   +0.01%     
==========================================
  Files         559      559              
  Lines       11627    11634       +7     
  Branches      835      835              
==========================================
+ Hits        11322    11330       +8     
  Misses        193      193              
+ Partials      112      111       -1
Impacted Files Coverage Δ
...ponents/date-picker/date-range-picker.component.ts 92.3% <100%> (+0.64%) ⬆️
...te-picker/lib/popups/date-range-popup.component.ts 97.29% <100%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c0d53...4d3cdb5. Read the comment docs.

@@ -99,6 +100,14 @@ export class DateRangePickerComponent extends AbstractPickerComponent implements
}
}

// Emit nzOnCalendarChange when select the first date by nz-range-picker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释改下吧,不是first date

@wilsoncook wilsoncook merged commit 4446005 into NG-ZORRO:master Apr 12, 2019
andrew-yangy pushed a commit to andrew-yangy/ng-zorro-antd that referenced this pull request Jun 20, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants