-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:date-picker): support nzOnCalendarChange
#3169
feat(module:date-picker): support nzOnCalendarChange
#3169
Conversation
stand calendarChange alone
add `nzOnCalendarChange` assert in date-picker 'should support nzOnChange' test case
…aoz/ng-zorro-antd into feat/DatePicker-nzOnCalendarChange
Deploy preview for ng-zorro-master ready! Built with commit 4d3cdb5 |
Codecov Report
@@ Coverage Diff @@
## master #3169 +/- ##
==========================================
+ Coverage 97.37% 97.38% +0.01%
==========================================
Files 559 559
Lines 11627 11634 +7
Branches 835 835
==========================================
+ Hits 11322 11330 +8
Misses 193 193
+ Partials 112 111 -1
Continue to review full report at Codecov.
|
@@ -99,6 +100,14 @@ export class DateRangePickerComponent extends AbstractPickerComponent implements | |||
} | |||
} | |||
|
|||
// Emit nzOnCalendarChange when select the first date by nz-range-picker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释改下吧,不是first date
了
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1509
What is the new behavior?
date-picker will support onCalendarChange
Does this PR introduce a breaking change?
Other information