Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:breadcrumb): fix auto generate not working in lazy modules #3174

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 27, 2019

close #2538

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Test is still blocked due to Angular's bug.

@netlify
Copy link

netlify bot commented Mar 27, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 62928d6

https://deploy-preview-3174--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #3174 into master will increase coverage by 0.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3174      +/-   ##
==========================================
+ Coverage   97.34%   97.35%   +0.01%     
==========================================
  Files         552      552              
  Lines       11587    11585       -2     
  Branches      827      827              
==========================================
  Hits        11279    11279              
+ Misses        195      193       -2     
  Partials      113      113
Impacted Files Coverage Δ
components/breadcrumb/nz-breadcrumb.component.ts 58.97% <40%> (+2.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0e319...62928d6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash模式breadcrumb问题
3 participants