-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(module:tree): change the collapsed of the treeNode to ngIf #3947
Conversation
Deploy preview for ng-zorro-master ready! Built with commit de1b6e3 |
测试有误,请修改一下。 |
Codecov Report
@@ Coverage Diff @@
## master #3947 +/- ##
==========================================
- Coverage 92.18% 92.17% -0.01%
==========================================
Files 520 520
Lines 11011 11013 +2
Branches 1995 1995
==========================================
+ Hits 10150 10151 +1
- Misses 430 431 +1
Partials 431 431
Continue to review full report at Codecov.
|
因为实现折叠的方式变了,之前的测试代码要修改,之前 @simplejason 说修改一直没改 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run
git fetch upstream
git pull --rebase upstream master
when you have synced codes with master, check https://github.com/simplejason/ng-zorro-antd/commit/a63700d9f0da2741f1c15e304fa80b989a7ace4e
to change your spec file.
we will merge it after testing passed |
Change the collapsed of the treeNode from display: none to *ngIf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ORRO#3947) Change the collapsed of the treeNode from display: none to *ngIf.
…ORRO#3947) Change the collapsed of the treeNode from display: none to *ngIf.
Change the collapsed of the treeNode from display: none to *ngIf.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #4182
Use
display: none
to collapse treeNode.What is the new behavior?
Change the collapsed of the treeNode from
display: none
to*ngIf
.Does this PR introduce a breaking change?
Other information