fix(module:code-editor): remove overflow styles #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit e2912ba |
Codecov Report
@@ Coverage Diff @@
## master #4016 +/- ##
=========================================
- Coverage 92.41% 92.4% -0.01%
=========================================
Files 506 506
Lines 10758 10758
Branches 1940 1940
=========================================
- Hits 9942 9941 -1
Misses 402 402
- Partials 414 415 +1
Continue to review full report at Codecov.
|
wzhudev
force-pushed
the
code-editor-overflow
branch
from
cd1f071
to
e92549f
Compare
wzhudev
force-pushed
the
code-editor-overflow
branch
from
0656931
to
e2912ba
Compare
simplejason
approved these changes
Aug 26, 2019
wzhudev
pushed a commit
to wzhudev/ng-zorro-antd
that referenced
this pull request
Aug 30, 2019
* fix(module:code-editor): remove overflow styles * docs: add tooltip to the complex demo * refactor: use types imported from monaco editor for better intellisense
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* fix(module:code-editor): remove overflow styles * docs: add tooltip to the complex demo * refactor: use types imported from monaco editor for better intellisense
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* fix(module:code-editor): remove overflow styles * docs: add tooltip to the complex demo * refactor: use types imported from monaco editor for better intellisense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
The context menu of monaco editor is cropped by borders of the container.
What is the new behavior?
Does this PR introduce a breaking change?
Other information