-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:breadcrumb): add nzRouteLabel
property
#4167
Conversation
Deploy preview for ng-zorro-master ready! Built with commit bb8a310 |
Codecov Report
@@ Coverage Diff @@
## master #4167 +/- ##
==========================================
- Coverage 92.27% 92.26% -0.01%
==========================================
Files 517 517
Lines 10961 10961
Branches 1985 1985
==========================================
- Hits 10114 10113 -1
Misses 422 422
- Partials 425 426 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some patches are required.
nzRouteDataBreadcrumbLabel
propertynzRouteLabel
property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@CK110 Thank you! This would be merged in the next minor version. |
* feat(module:breadcrumb): add `nzRouteDataBreadcrumbLabel` property * feat(module:breadcrumb): change property to `nzRouteLabel`
* feat(module:breadcrumb): add `nzRouteDataBreadcrumbLabel` property * feat(module:breadcrumb): change property to `nzRouteLabel`
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3775
What is the new behavior?
Does this PR introduce a breaking change?
Other information