Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:auto-complete): not emit changes when retype same value while open #4215

Merged
merged 2 commits into from
Oct 12, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Sep 25, 2019

Deploy preview for ng-zorro-master ready!

Built with commit e2351bd

https://deploy-preview-4215--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #4215 into master will decrease coverage by <.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4215      +/-   ##
==========================================
- Coverage   92.31%   92.31%   -0.01%     
==========================================
  Files         519      519              
  Lines       10963    10968       +5     
  Branches     1984     1986       +2     
==========================================
+ Hits        10121    10125       +4     
- Misses        419      420       +1     
  Partials      423      423
Impacted Files Coverage Δ
...auto-complete/nz-autocomplete-trigger.directive.ts 96.03% <88.88%> (+0.16%) ⬆️
components/typography/nz-typography.component.ts 97.93% <0%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704c34f...e2351bd. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 21e91e3 into NG-ZORRO:master Oct 12, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…ile open (NG-ZORRO#4215)

* fix(module:auto-complete): not emit changes when retype same value while open

* test(module:auto-complete): add test
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…ile open (NG-ZORRO#4215)

* fix(module:auto-complete): not emit changes when retype same value while open

* test(module:auto-complete): add test
@hsuanxyz hsuanxyz deleted the fix/autocomplete-empty branch August 5, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants