Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:select): support default value not in the option list #4261

Merged
merged 1 commit into from
Oct 10, 2019
Merged

feat(module:select): support default value not in the option list #4261

merged 1 commit into from
Oct 10, 2019

Conversation

vthinkxie
Copy link
Member

close #3672 close #4000

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Oct 10, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 0940e36

https://deploy-preview-4261--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #4261 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4261      +/-   ##
==========================================
- Coverage   92.29%   92.28%   -0.01%     
==========================================
  Files         520      520              
  Lines       10977    10978       +1     
  Branches     1988     1988              
==========================================
  Hits        10131    10131              
  Misses        422      422              
- Partials      424      425       +1
Impacted Files Coverage Δ
components/select/nz-option.pipe.ts 100% <100%> (ø) ⬆️
components/select/nz-option.component.ts 100% <100%> (ø) ⬆️
components/dropdown/nz-dropdown.component.ts 93.75% <0%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 120c5be...0940e36. Read the comment docs.

@vthinkxie vthinkxie merged commit 51b26b4 into NG-ZORRO:master Oct 10, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants