Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:time-picker): add null input judgement when using datefns #4283

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Oct 12, 2019

Close #3854

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Oct 12, 2019

Codecov Report

Merging #4283 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4283      +/-   ##
==========================================
- Coverage   92.18%   92.17%   -0.01%     
==========================================
  Files         520      520              
  Lines       11005    11005              
  Branches     1995     1996       +1     
==========================================
- Hits        10145    10144       -1     
  Misses        429      429              
- Partials      431      432       +1
Impacted Files Coverage Δ
components/i18n/date-helper.service.ts 68% <0%> (-4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1bba9e...da6e1f0. Read the comment docs.

@netlify
Copy link

netlify bot commented Oct 12, 2019

Deploy preview for ng-zorro-master ready!

Built with commit da6e1f0

https://deploy-preview-4283--ng-zorro-master.netlify.com

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timepicker has a default value(08:00:00) when use 'date-fns'
3 participants