Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:typography): support nzSuffix property #4629

Merged
merged 4 commits into from
Feb 26, 2020

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Jan 3, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4620

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: draft label Jan 3, 2020
@zorro-bot
Copy link

zorro-bot bot commented Jan 3, 2020

This preview will be available after the TravisCI is passed.

@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #4629 into master will increase coverage by 0.02%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4629      +/-   ##
==========================================
+ Coverage   93.18%   93.21%   +0.02%     
==========================================
  Files         501      501              
  Lines       12749    12772      +23     
  Branches     1957     1962       +5     
==========================================
+ Hits        11880    11905      +25     
+ Misses        457      454       -3     
- Partials      412      413       +1
Impacted Files Coverage Δ
components/core/util/text-measure.ts 91.3% <100%> (+2.8%) ⬆️
components/typography/nz-typography.component.ts 97.76% <92.3%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7df349...6bbff7b. Read the comment docs.

@hsuanxyz hsuanxyz marked this pull request as ready for review January 6, 2020 10:40
@pr-triage pr-triage bot removed the PR: draft label Jan 6, 2020
@wenqi73 wenqi73 requested a review from wzhudev February 3, 2020 08:22
wzhudev
wzhudev previously approved these changes Feb 3, 2020
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit ca02a07 into NG-ZORRO:master Feb 26, 2020
@pr-triage pr-triage bot added the PR: merged label Feb 26, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:typography): support `nzSuffix` property

close NG-ZORRO#4620

* test(module:typography): add the suffix test

* test(module:typography): add the suffix test

* fix(module:typography): fix the template
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:typography): support `nzSuffix` property

close NG-ZORRO#4620

* test(module:typography): add the suffix test

* test(module:typography): add the suffix test

* fix(module:typography): fix the template
@hsuanxyz hsuanxyz deleted the feat/typography-suffix branch August 5, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants