Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tree-view): add tree-view component #6161

Merged
merged 1 commit into from Dec 16, 2020

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Dec 8, 2020

close #5976, close #5809, close #5739, close #5736, close #5519, close #5446, close #5152, close #4694, close #4472, close #3832, close #2785, close #2744, close #6199

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5976, #5809, #5739, #5736, #5519, #5446, #5152, #4694, #4472, #3832, #2785, #2744, #6199

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: draft label Dec 8, 2020
@zorro-bot
Copy link

zorro-bot bot commented Dec 8, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #6161 (3afe868) into master (e8e1c6c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6161      +/-   ##
==========================================
+ Coverage   89.83%   89.84%   +0.01%     
==========================================
  Files         477      477              
  Lines       15205    15205              
  Branches     2301     2301              
==========================================
+ Hits        13659    13661       +2     
+ Misses        950      949       -1     
+ Partials      596      595       -1     
Impacted Files Coverage Δ
components/core/animation/collapse.ts 100.00% <ø> (ø)
components/tree/tree.component.ts 92.65% <ø> (ø)
components/tree/tree.module.ts 100.00% <ø> (ø)
components/tree/tree-node-checkbox.component.ts 100.00% <100.00%> (ø)
components/tree/tree-node.component.ts 90.00% <100.00%> (ø)
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8e1c6c...3afe868. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the feat/tree-controller branch 2 times, most recently from 51fa956 to c98aff6 Compare December 8, 2020 06:08
Copy link
Contributor

@yangjunhan yangjunhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document translation modifications.

components/tree-view/doc/index.en-US.md Outdated Show resolved Hide resolved
components/tree-view/doc/index.en-US.md Outdated Show resolved Hide resolved
components/tree-view/doc/index.en-US.md Outdated Show resolved Hide resolved
components/tree-view/doc/index.en-US.md Outdated Show resolved Hide resolved
components/tree-view/doc/index.en-US.md Outdated Show resolved Hide resolved
components/tree-view/doc/index.en-US.md Outdated Show resolved Hide resolved
components/tree-view/doc/index.en-US.md Outdated Show resolved Hide resolved
components/tree-view/doc/index.en-US.md Outdated Show resolved Hide resolved
components/tree-view/doc/index.en-US.md Outdated Show resolved Hide resolved
components/tree-view/doc/index.zh-CN.md Outdated Show resolved Hide resolved
@hsuanxyz hsuanxyz force-pushed the feat/tree-controller branch 5 times, most recently from 13a550d to 171a7bb Compare December 9, 2020 04:08
components/tree-view/style/index.less Show resolved Hide resolved
components/tree-view/tree-view.ts Show resolved Hide resolved
components/tree-view/tree-view.ts Outdated Show resolved Hide resolved
@hsuanxyz hsuanxyz marked this pull request as ready for review December 14, 2020 06:12
@hsuanxyz hsuanxyz merged commit 05d58de into NG-ZORRO:master Dec 16, 2020
@hsuanxyz hsuanxyz deleted the feat/tree-controller branch December 16, 2020 05:15
@pr-triage pr-triage bot added the PR: merged label Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment