Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:input): fix input disable style in reactive form #1167

Merged
merged 1 commit into from
Mar 18, 2018
Merged

fix(module:input): fix input disable style in reactive form #1167

merged 1 commit into from
Mar 18, 2018

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
close #1166

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Mar 18, 2018

Codecov Report

Merging #1167 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1167      +/-   ##
==========================================
- Coverage   96.76%   96.75%   -0.02%     
==========================================
  Files         184      184              
  Lines        7581     7583       +2     
  Branches      989      990       +1     
==========================================
+ Hits         7336     7337       +1     
- Misses         55       56       +1     
  Partials      190      190
Impacted Files Coverage Δ
components/input/nz-input.directive.ts 96.29% <100%> (+0.14%) ⬆️
components/table/nz-table.component.ts 94.83% <0%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd03d7...77def75. Read the comment docs.

@vthinkxie vthinkxie merged commit 5c07161 into NG-ZORRO:master Mar 18, 2018
@vthinkxie vthinkxie deleted the fix-input-disable branch October 10, 2018 02:49
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input在响应式表单中的HTML模板设置disabled属性会出现警告
1 participant