Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:input,datepicker,input-number,select,slider): still dirty when "form.reset()" called #257

Merged
merged 1 commit into from
Sep 9, 2017

Conversation

wilsoncook
Copy link
Member

@wilsoncook wilsoncook commented Sep 9, 2017

change the "writeValue" to not trigger "view -> control updating" while "control -> view updating"

close #114

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #114

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Coverage remained the same at 41.15% when pulling ef25dec on wilsoncook:bug_114 into cd5b511 on NG-ZORRO:master.

…when "form.reset()" called

change the "writeValue" to not trigger "view -> control updating" while "control -> view updating"

close NG-ZORRO#114
@wilsoncook wilsoncook changed the title fix(module:input): the nz-input in reactive form is dirty even called "form.reset()" fix(module:input,datepicker,input-number,select,slider): still dirty when "form.reset()" called Sep 9, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 41.218% when pulling 325d30f on wilsoncook:bug_114 into cd5b511 on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit 4233db1 into NG-ZORRO:master Sep 9, 2017
@wilsoncook wilsoncook deleted the bug_114 branch September 10, 2017 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

表单重置未生效?
3 participants