feat(module:message): support template #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3102 +/- ##
==========================================
+ Coverage 97.32% 97.32% +<.01%
==========================================
Files 550 550
Lines 11526 11527 +1
Branches 824 824
==========================================
+ Hits 11218 11219 +1
Misses 199 199
Partials 109 109
Continue to review full report at Codecov.
|
|
Deploy preview for ng-zorro-master ready! Built with commit 3029d03 |
hsuanxyz
reviewed
Mar 20, 2019
| }) | ||
| export class DemoAppComponent {} | ||
| export class DemoAppComponent { |
wzhudev
force-pushed
the
message-template
branch
from
84ea84f
to
62c729d
Compare
hsuanxyz
approved these changes
Mar 20, 2019
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* feat(module:message): support template * docs: update content type * fix: createMessage * fix: lint * fix: test close NG-ZORRO#3081
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* feat(module:message): support template * docs: update content type * fix: createMessage * fix: lint * fix: test close NG-ZORRO#3081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3081
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
A user cannot pass a
TemplateReftocontent. They have to use inline HTML.Issue Number: #3081
What is the new behavior?
Now a user can pass a
TemplateRef<void>tocontent.Does this PR introduce a breaking change?
Other information