Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support server-side rendering #3295

Merged
merged 3 commits into from
Apr 19, 2019
Merged

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3222, #43, #1923, #2025, #2474

What is the new behavior?

https://demo.zorro-ssr.hsuan.xyz/feedback

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Apr 18, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 6c85d9b

https://deploy-preview-3295--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #3295 into master will decrease coverage by 0.04%.
The diff coverage is 91.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3295      +/-   ##
==========================================
- Coverage   97.48%   97.44%   -0.05%     
==========================================
  Files         606      606              
  Lines       11890    11928      +38     
  Branches      868      869       +1     
==========================================
+ Hits        11591    11623      +32     
- Misses        190      196       +6     
  Partials      109      109
Impacted Files Coverage Δ
components/menu/nz-submenu.component.ts 98.83% <100%> (+0.04%) ⬆️
components/timeline/nz-timeline.component.ts 98% <100%> (+0.04%) ⬆️
components/statistic/nz-countdown.component.ts 93.75% <100%> (+0.2%) ⬆️
components/anchor/nz-anchor-link.component.ts 100% <100%> (ø) ⬆️
components/select/nz-select.component.ts 98.01% <100%> (+0.02%) ⬆️
components/avatar/nz-avatar.component.ts 100% <100%> (ø) ⬆️
components/slider/nz-slider.component.ts 94.93% <100%> (+0.02%) ⬆️
components/carousel/nz-carousel.component.ts 97.1% <50%> (-0.71%) ⬇️
components/table/nz-table.component.ts 97.1% <66.66%> (-0.68%) ⬇️
components/upload/nz-upload-list.component.ts 98.64% <75%> (-1.36%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da4b68...6c85d9b. Read the comment docs.

close NG-ZORRO#3222, close NG-ZORRO#43
ref NG-ZORRO#2025,NG-ZORRO#2474

style: fix lint

docs: add the docs

docs: fix ssr docs

docs: update README

chore: rebase
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 2088459 into NG-ZORRO:master Apr 19, 2019
@vthinkxie vthinkxie mentioned this pull request Apr 19, 2019
12 tasks
@hsuanxyz hsuanxyz deleted the feat/ssr branch April 22, 2019 02:39
andrew-yangy pushed a commit to andrew-yangy/ng-zorro-antd that referenced this pull request Jun 20, 2019
* feat: support server-side rendering

close NG-ZORRO#3222, close NG-ZORRO#43
ref NG-ZORRO#2025,NG-ZORRO#2474

style: fix lint

docs: add the docs

docs: fix ssr docs

docs: update README

chore: rebase

* style: fix lint

* docs: fix README
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat: support server-side rendering

close NG-ZORRO#3222, close NG-ZORRO#43
ref NG-ZORRO#2025,NG-ZORRO#2474

style: fix lint

docs: add the docs

docs: fix ssr docs

docs: update README

chore: rebase

* style: fix lint

* docs: fix README
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat: support server-side rendering

close NG-ZORRO#3222, close NG-ZORRO#43
ref NG-ZORRO#2025,NG-ZORRO#2474

style: fix lint

docs: add the docs

docs: fix ssr docs

docs: update README

chore: rebase

* style: fix lint

* docs: fix README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants