Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): sort range picker value when start is after end #3956

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Aug 10, 2019

close #3940, close #1642

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Aug 10, 2019

Deploy preview for ng-zorro-master ready!

Built with commit ff39aaa

https://deploy-preview-3956--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Aug 11, 2019

Codecov Report

Merging #3956 into master will increase coverage by 0.01%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3956      +/-   ##
==========================================
+ Coverage   95.33%   95.34%   +0.01%     
==========================================
  Files         778      778              
  Lines       14868    14868              
  Branches     1916     1915       -1     
==========================================
+ Hits        14174    14176       +2     
  Misses        260      260              
+ Partials      434      432       -2
Impacted Files Coverage Δ
...te-picker/lib/popups/date-range-popup.component.ts 96.24% <90.9%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a6550b...ff39aaa. Read the comment docs.

@wenqi73 wenqi73 requested a review from wzhudev August 11, 2019 12:45
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 117b453 into NG-ZORRO:master Aug 13, 2019
@wenqi73 wenqi73 deleted the range-input branch October 25, 2019 03:00
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…end (NG-ZORRO#3956)

* fix(module:date-picker): sort range picker value when start is after end

* fix: test

close NG-ZORRO#3940, close NG-ZORRO#1642
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…end (NG-ZORRO#3956)

* fix(module:date-picker): sort range picker value when start is after end

* fix: test

close NG-ZORRO#3940, close NG-ZORRO#1642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants