Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): sort range picker value when start is after end #3956

Merged
merged 2 commits into from Aug 13, 2019

Conversation

@wenqi73
Copy link
Member

commented Aug 10, 2019

close #3940, close #1642

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: unreviewed label Aug 10, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 10, 2019

Deploy preview for ng-zorro-master ready!

Built with commit ff39aaa

https://deploy-preview-3956--ng-zorro-master.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 11, 2019

Codecov Report

Merging #3956 into master will increase coverage by 0.01%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3956      +/-   ##
==========================================
+ Coverage   95.33%   95.34%   +0.01%     
==========================================
  Files         778      778              
  Lines       14868    14868              
  Branches     1916     1915       -1     
==========================================
+ Hits        14174    14176       +2     
  Misses        260      260              
+ Partials      434      432       -2
Impacted Files Coverage Δ
...te-picker/lib/popups/date-range-popup.component.ts 96.24% <90.9%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a6550b...ff39aaa. Read the comment docs.

@wenqi73 wenqi73 requested a review from wendzhue Aug 11, 2019

@wendzhue
Copy link
Member

left a comment

lgtm

@vthinkxie
Copy link
Member

left a comment

LGTM

@vthinkxie vthinkxie merged commit 117b453 into NG-ZORRO:master Aug 13, 2019

5 of 9 checks passed

codecov/patch 90.9% of diff hit (target 95.33%)
Details
Header rules No header rules processed
Details
Pages changed 2 new files uploaded
Details
Redirect rules No redirect rules processed
Details
CodeFactor No issues found.
Details
Mixed content No mixed content detected
Details
codecov/project 95.34% (+0.01%) compared to 5a6550b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.