Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:time-picker): allow inputting string type #4949

Merged
merged 3 commits into from
Apr 1, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Mar 27, 2020

Fixes #4775
Fixes #4777
Fixed #4871

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #4949 into master will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4949   +/-   ##
=======================================
  Coverage   91.55%   91.55%           
=======================================
  Files         535      535           
  Lines       13686    13692    +6     
  Branches     2043     2045    +2     
=======================================
+ Hits        12530    12536    +6     
+ Misses        693      690    -3     
- Partials      463      466    +3     
Impacted Files Coverage Δ
components/i18n/date-helper.service.ts 87.50% <66.66%> (+0.65%) ⬆️
...ponents/time-picker/time-picker-panel.component.ts 92.88% <100.00%> (-0.73%) ⬇️
components/time-picker/time-picker.component.ts 94.00% <100.00%> (+0.18%) ⬆️
...nents/time-picker/time-value-accessor.directive.ts 91.30% <100.00%> (ø)
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/time-picker/time-holder.ts 96.64% <0.00%> (-0.68%) ⬇️
components/table/src/table/tr-measure.component.ts 100.00% <0.00%> (+13.04%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ecdb9...20b6d02. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 3b45a22 into NG-ZORRO:master Apr 1, 2020
@wenqi73 wenqi73 deleted the timepicker-value branch April 1, 2020 07:30
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* fix(module:time-picker): allow inputting string type

Fixes NG-ZORRO#4775, Fixes NG-ZORRO#4777, Fixed NG-ZORRO#4871, close NG-ZORRO#1679
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix(module:time-picker): allow inputting string type

Fixes NG-ZORRO#4775, Fixes NG-ZORRO#4777, Fixed NG-ZORRO#4871, close NG-ZORRO#1679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants